Fix and re-instate Babbage simpleRewards test#2058
Open
Lucsanszky wants to merge 2 commits intomasterfrom
Open
Fix and re-instate Babbage simpleRewards test#2058Lucsanszky wants to merge 2 commits intomasterfrom
simpleRewards test#2058Lucsanszky wants to merge 2 commits intomasterfrom
Conversation
Lucsanszky
force-pushed
the
ldan/simpleRewards-fix
branch
from
3419232 to
1cbadbe
Compare
Author
|
It seems like I broke some tests re: reward registrations. Once I get back from my vacation, I'll fix them but if someone would like to takeover in the meantime and finish this, then feel free to do so. |
Contributor
|
Thank you for looking into this! I'll take a look |
`allPoolStakeCert` needed some adjustments after the `UMap` purge in `cardano-ledger` and had to make sure that we don't re-register already registered staking credentials. Also, because validations were turned off apparently, `FailedToValidateSlot` was not triggered but rather we ended up in an invalid state (the associated delegations were dropped in the account state), thus resulting in a test failure. With validation, attempting to re-register already registered staking credentials would trigger the `StakeKeyAlreadyRegisteredDELEG` predicate failure as per the `DELEG` rule.
Lucsanszky
force-pushed
the
ldan/simpleRewards-fix
branch
from
cc11155 to
902241b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the conclusion of the following investigation: IntersectMBO/cardano-ledger#5477
allPoolStakeCertneeded some adjustments after theUMappurge incardano-ledgerand had to make sure that we don't re-register already registered staking credentials. Also, because validations were turned off apparently,FailedToValidateSlotwas not triggered but rather we ended up in an invalid state (the associated delegations were dropped in the account state), thus resulting in a test failure. With validation, attempting to re-register already registered staking credentials would trigger theStakeKeyAlreadyRegisteredDELEGpredicate failure as per theDELEGrule.Checklist
fourmoluon version 0.17.0.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.