Open
Conversation
908cfc2 to
78fde31
Compare
45a379a to
7abaec9
Compare
d067c16 to
7dc1377
Compare
67519c7 to
35d7408
Compare
Minimize cabal dependencies Handle unavailable port nix | cabal.project: bump CHaP and cardano-automation Use unix-compat with tests
35d7408 to
8d77939
Compare
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an end-to-end test for the metrics pipeline, covering everything from tracing a metric to scraping it via the Prometheus endpoint and validating the result. It is the first full-round verification of our metrics infrastructure.
Motivation
Until now, our metrics tests were mostly unit-level or partial integration checks. This new test ensures that:
This increases confidence in the observability layer, especially ahead of future instrumentation work.
What the Test Does
Thread 1
localhost:9090.ekgTracerand configures it.Measure 42metric.Thread 2
http://localhost:9090/metrics."measure"metric and asserts its value is42.On success, prints
Got correct metric value ✔.