Skip to content

bench: maintenance#6480

Open
fmaste wants to merge 5 commits intomasterfrom
bench-master
Open

bench: maintenance#6480
fmaste wants to merge 5 commits intomasterfrom
bench-master

Conversation

@fmaste
Copy link
Copy Markdown
Contributor

@fmaste fmaste commented Mar 9, 2026

This PR contains various maintenance items for P&T

  • Adjustments to TraceOptions to address various Reflection.TracerConsistencyWarnings
  • Slight increase of forwarding queue capacity for bench nodes
  • Fix non-flake workbench creation for profiled builds (fixes *-profnix shells)
  • cardano-node: use human-readable (not scientific) notation for block replay progress trace messages
  • locli: ability to extract timestamps from an incomplete last log line (as in tail -n1 stdout)
  • Forward compatibility for tx-generator and cardano-tracer for the next release of trace-dispatcher (cardano-node not affected).
  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@mgmeier mgmeier force-pushed the bench-master branch 5 times, most recently from 51edcb3 to 81e3546 Compare April 2, 2026 09:45
@mgmeier mgmeier changed the title wb | fix for non-flake workbench creation using incorrect haskell pro… bench: maintenance Apr 2, 2026
@mgmeier mgmeier marked this pull request as ready for review April 2, 2026 09:58
@mgmeier mgmeier requested review from a team as code owners April 2, 2026 09:58
Copy link
Copy Markdown
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgmeier mgmeier added this pull request to the merge queue Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2026
@mgmeier mgmeier added this pull request to the merge queue Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 2, 2026
@mgmeier mgmeier added this pull request to the merge queue Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 2, 2026
@fmaste fmaste added this pull request to the merge queue Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants