Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 57 57
Lines 2741 2741
Branches 819 820 +1
=======================================
Hits 2042 2042
- Misses 658 698 +40
+ Partials 41 1 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mprew97
approved these changes
Oct 28, 2025
Contributor
mprew97
left a comment
There was a problem hiding this comment.
LGTM, left a minor question/suggestion.
| import { test, expect } from '@playwright/test'; | ||
| import { UUATestingPage } from './page-objects/pages/UUATestingPage'; | ||
|
|
||
| test.describe('UUA Testing Endpoints', () => { |
Contributor
There was a problem hiding this comment.
any reason for the deletion of this file?
Contributor
Author
There was a problem hiding this comment.
It was a first test written to help CI configure. will do follow up phases to increase test coverage for embedded messaging and UUA like what's done here for inapp
| @@ -1,7548 +0,0 @@ | |||
| Arguments: | |||
Contributor
There was a problem hiding this comment.
we should add these files to .gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description
Playwright E2E Test Suite for Web SDK
🎯 Overview
This PR adds a comprehensive, production-ready Playwright test suite for the Iterable Web SDK, focusing on in-app messaging features.
Key Stats:
📁 Test File Structure
🧪 Test Coverage
1. SDK Authentication (1 test)
setEmail()method validation2. Message Retrieval & Filtering (5 tests)
3. Error Handling (2 tests)
4. Display Positioning (6 tests)
5. Special URL Handling (2 tests)
iterable://protocol transformationaction://protocol transformation6. Close Button Features (3 tests)
7. Priority Sorting (1 test)
8. Real API Integration (4 tests)
🏗️ Architecture Highlights
Page Object Model (POM)
Clean separation of test logic and page interactions:
Custom Fixtures
Automatic setup/teardown for common scenarios:
Message Factory Pattern
Consistent, reusable message creation:
DRY Principles
test-constants.ts)message-helpers.ts)message-factory.ts)🎯 What We Test (Philosophy)
✅ SDK Behavior
✅ Integration Points
📈 Test Execution Time
Total CI Time: ~4-5 minutes (parallel execution)