Merged
Conversation
JasmineRRod
approved these changes
Apr 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Linux (Debian/Ubuntu) packaging metadata to make the generated .deb installable across Ubuntu releases that have either libasound2 (e.g., 22.04) or libasound2t64 (newer releases), addressing runtime library compatibility for the JDK/AWT stack.
Changes:
- Updated the DEBIAN/control template to depend on
libasound2t64 | libasound2in addition toopenjdk-25-jre. - Added
jpackageargument--linux-package-depsfor the “fat” DEB build to includelibasound2t64 | libasound2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
319
to
321
| Architecture: all | ||
| Depends: openjdk-25-jre | ||
| Depends: openjdk-25-jre, libasound2t64 | libasound2 | ||
| Maintainer: JDiskMark Team |
Comment on lines
+410
to
+411
| <arg value="--linux-package-deps" /> | ||
| <arg value="libasound2t64 | libasound2" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for ubuntu 22.04 lts by making jdk work with the previous library.