[DRAFT] Refactorización de estados de UserTicket a enums y mejora de documentación#275
Draft
[DRAFT] Refactorización de estados de UserTicket a enums y mejora de documentación#275
Conversation
- Replace string literals with UserTicketApprovalStatus and -UserTicketRedemptionStatus enums - Update related code and tests to use new enum types - Improve maintainability across user ticket handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Este PR propone re-factorizar cómo manejamos los estados de los tickets de usuario (UserTicket).
Los principales cambios y ventajas que veo con este cambio son los siguientes:
Introducción de enums: Se han creado
UserTicketApprovalStatusyUserTicketRedemptionStatusreemplazando las cadenas de texto literales.Facilidad de navegación en el código:
Documentación inline mejorada:
Mantenimiento de la seguridad de tipos:
Actualización del código y pruebas:
Puntos para discusión:
Como verán definí una documentación inicial para cada estado pero no tengo claro cual era la idea con algunos estados como "rejected" o "gift_accepted", por lo que necesitaría de su ayuda para definir esa documentación.