fix: allowing skyline keywords as columns, tables, etc.#2137
Merged
manticore-projects merged 8 commits intoJSQLParser:masterfrom Jan 7, 2025
Merged
fix: allowing skyline keywords as columns, tables, etc.#2137manticore-projects merged 8 commits intoJSQLParser:masterfrom
manticore-projects merged 8 commits intoJSQLParser:masterfrom
Conversation
Contributor
|
Greetings! Thank you for your contribution and good job overall. However, the grammar has some ambiguities now: Please fix by inserting the advised LOOKAHEADS. Then I would merge. |
6e488c0 to
9eeb92f
Compare
Contributor
Author
|
@manticore-projects Thanks for reviewing
Ive made this change -> 9eeb92f |
Contributor
|
Good job, thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from this PR -> #2078
Associated to this issue -> #2136
The keywords LOW, HIGH, PLUS and INVERSE were missing from line 2048 of
JSqlParserCC.jjtas they were added as new restricted keywords. I have added them manually to line 2048 and removed them as restricted keywords.I could have done the same with PREFERRING, but since #2078 was merged its become an important new keyword like WHERE, so Ive left it out.