Add support for AllTableColumns in PrimaryExpression#2197
Conversation
|
Thank you for this contribution. My understanding is: A However, we segregate both Expression at other places already and I believe even have to use semantic lookaheads (which are expensive). So in my opinion, we either a) keep segregating What I will not want is a mix of both approaches because it can make the Grammar even harder to maintain in the future. |
a0665a2 to
2e27ef1
Compare
|
@manticore-projects, thanks, makes total sense.
I went with the approach above, so I removed the segregation of Looking forward to hearing your thoughts. |
PostgreSQL supports expressions such as
posts.*(all columns from thepoststable) in many places, such as theGROUP BYclause.For example, in this query:
This PR adds support for AllTableColumns in PrimaryExpression.
I wasn't sure if PrimaryExpression is the best fit for this, so will be happy for suggestions on relocating it if there's a better expression group for it.