fix(finalize-pr): remove pre-PR steps from workflow diagram#76
fix(finalize-pr): remove pre-PR steps from workflow diagram#76JacobPEvans merged 2 commits intomainfrom
Conversation
The workflow section showed /init-worktree, implementation, and gh pr create steps before /finalize-pr, causing AI to recommend this skill at the point of committing and opening a PR. The skill only applies post-PR-creation. (claude)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for the /finalize-pr skill by streamlining its workflow diagram and adding explicit usage instructions. The primary goal is to clarify that this skill is intended for post-PR finalization, thereby preventing its premature recommendation by AI agents and ensuring users understand its correct application within the development lifecycle. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request effectively clarifies the usage of the /finalize-pr skill by removing the pre-PR creation steps from the workflow diagram and explicitly stating that the skill should only be used after a pull request has already been created. This change aligns with the objective of preventing AI agents from recommending /finalize-pr at the commit/PR-creation stage and improves the clarity of the documentation.
Note: Security Review has been skipped due to the limited scope of the PR.
Greptile SummaryThis PR tightens the scope of the
Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["PR already exists"] --> B["/finalize-pr [number]"]
B --> P1["Phase 1: Resolve PR number"]
P1 --> P2["Phase 2: Resolution Loop (automatic fixes)"]
P2 --> P3["Phase 3: Pre-Handoff Verification"]
P3 --> P4["Phase 4: Update PR Metadata"]
P4 --> P5["Phase 5: Report ready (wait for user)"]
P5 --> U["User invokes: /squash-merge-pr or /rebase-pr"]
style A fill:#f9f,stroke:#333,stroke-width:2px
style B fill:#bbf,stroke:#333
Last reviewed commit: 95e6b6b |
There was a problem hiding this comment.
Pull request overview
Updates the /finalize-pr skill documentation to clearly scope the workflow to post-PR usage, removing misleading pre-PR steps from the workflow diagram so agents/users don’t apply it during PR creation.
Changes:
- Removes the
/init-worktree → [implement] → gh pr create →prefix from the “Single PR” workflow diagram. - Adds an explicit note that
/finalize-prshould be used only after a PR exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…iagram Workflow diagram showed only `/finalize-pr [number]` but the skill also supports no-arg current-branch mode. Updated to show both forms explicitly. (claude)
|
Claude finished @JacobPEvans's task in 1m 53s —— View job PR Review
No issues found. This is a documentation-only change confined to the The changes are correct and well-scoped:
LGTM. |
Conflicts resolved: - AGENTS.md: keep HEAD minimal version (sections duplicated from CLAUDE.md removed) - content-guards/scripts/validate-markdown.sh: keep short comment, adopt --no-must-find-files flag from main (cspell fix) - git-workflows/skills/init-worktree/SKILL.md: keep deleted (externalized) - github-workflows/skills/finalize-pr/SKILL.md: take main's diagram (shows both invocation modes + multi-PR modes from PR #76) (claude)
Summary
/init-worktree → [implement] → gh pr create →prefix from the Single PR workflow diagram/finalize-prat the commit/PR-creation stageTest plan
/finalize-prwhen asked to commit and open a PR🤖 Generated with Claude Code