Skip to content

fix(release): replace bump-minor-pre-major with versioning always-bump-minor#89

Merged
JacobPEvans merged 1 commit intomainfrom
fix/prevent-major-releases
Mar 6, 2026
Merged

fix(release): replace bump-minor-pre-major with versioning always-bump-minor#89
JacobPEvans merged 1 commit intomainfrom
fix/prevent-major-releases

Conversation

@JacobPEvans
Copy link
Owner

Summary

  • Replaces deprecated bump-minor-pre-major: true with versioning: always-bump-minor
  • Adds breaking changelog section (consistent with central config)
  • Fixes ordering of changelog-sections to match central config

Context

PR #86 (chore(main): release 2.0.0) was generated because release-please interpreted a BREAKING CHANGE footer in a commit as requiring a major bump. The reusable workflow injects versioning: always-bump-minor from the central config at runtime, but the local config was stale and causing confusion.

This update:

  1. Makes the local config the source of truth (not just documentation) by using versioning instead of the deprecated flag
  2. Ensures future devs reading the local config see the correct versioning strategy

PR #86 has been closed and the release-please--branches--main branch deleted to force recalculation. After this merges, release-please will create a correct v1.x.x PR.

Test plan

  • Verify this PR merges cleanly
  • Confirm release-please auto-creates a new PR with v1.x.x (not v2.0.0) after merge

🤖 Generated with Claude Code

…p-minor

Switch from the deprecated bump-minor-pre-major flag to the explicit
versioning: always-bump-minor strategy. This ensures major version bumps
(from BREAKING CHANGE commits) are always capped at minor regardless of
commit type. Also adds the 'breaking' changelog section.

Relates to: stale v2.0.0 release-please PR #86, now closed.

(claude)
Copilot AI review requested due to automatic review settings March 6, 2026 22:57
@claude
Copy link
Contributor

claude bot commented Mar 6, 2026

Claude finished @JacobPEvans's task in 41s —— View job


PR Review: fix(release): replace bump-minor-pre-major with versioning always-bump-minor

  • Gather context and read changed files
  • Analyze the diff
  • Post review

The change is correct and well-motivated. No blocking issues.

bump-minor-pre-majorversioning: always-bump-minor — This is the right migration. bump-minor-pre-major was deprecated in release-please v4+ in favor of the versioning strategy field. Using always-bump-minor correctly ensures breaking changes bump minor (not major) regardless of BREAKING CHANGE footers in commits.

breaking changelog section — Worth noting: this maps to commits with literal type breaking: (e.g. breaking: some change), not to commits with a BREAKING CHANGE: footer. Footers are handled separately by release-please's versioning logic. If the intent is to surface breaking-change commits in the changelog, they'd need to use breaking: as the commit type. If this is just for parity with the central config, that's fine — it's a no-op for conventional feat! or BREAKING CHANGE footer commits.

Ordering fix — Correct, and consistent with central config.

Overall: LGTM. The fix directly addresses the root cause of the spurious v2.0.0 PR.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s local Release Please configuration to match the current release strategy and central configuration expectations, reducing confusion and preventing unintended major bumps while still pre-1.0.

Changes:

  • Replaces deprecated bump-minor-pre-major with versioning: always-bump-minor.
  • Adds a breaking changelog section.
  • Reorders changelog-sections entries to align with the central configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps
Copy link

greptile-apps bot commented Mar 6, 2026

Greptile Summary

This PR updates release-please-config.json to replace the deprecated bump-minor-pre-major: true flag with versioning: "always-bump-minor", and aligns the changelog-sections ordering and entries with the central reusable workflow config.

Key changes:

  • versioning: "always-bump-minor" replaces the deprecated bump-minor-pre-major: true. The old flag only suppressed major bumps while the project version was below 1.0.0; the new strategy suppresses major bumps unconditionally — which is the correct behaviour for this repo and matches what the central reusable workflow already injects at runtime.
  • breaking changelog section is added (visible, not hidden) to surface any breaking:-typed commits in the changelog, consistent with the central config.
  • Section reorder moves ci before docs and test to last — purely cosmetic alignment with central config.

This single-file change is safe to merge. The configuration now correctly reflects the release strategy and will prevent the false v2.0.0 bump that occurred in PR #86.

Confidence Score: 5/5

  • Single-file config-only change with zero logic or syntax issues; safe to merge.
  • This PR is safe to merge — it is a minimal, single-file JSON configuration change with clear, well-documented motivation. The replacement of the deprecated flag with versioning: "always-bump-minor" is the correct modern approach and directly fixes the v2.0.0 miscalculation described in the PR context. The added breaking changelog section and section reordering are intentional and consistent with central config. No logic errors, syntax errors, or regressions identified.
  • No files require special attention

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Commit lands on main] --> B{Commit type?}
    B -- "feat: ..." --> C[Minor bump]
    B -- "fix: / perf: ..." --> D[Patch bump]
    B -- "feat!: ... OR BREAKING CHANGE footer" --> E{versioning strategy?}
    B -- "chore: / ci: / docs: / refactor: / test: ..." --> F[No version bump\nhidden in changelog]
    B -- "breaking: ..." --> G[Patch bump\nvisible in Breaking Changes section]
    E -- "bump-minor-pre-major: true\n(old / deprecated)" --> H{Is version < 1.0.0?}
    H -- yes --> I[Minor bump]
    H -- no --> J[Major bump ⚠️]
    E -- "versioning: always-bump-minor\n(new / this PR)" --> K[Always Minor bump\nregardless of version]
    C --> L[release-please opens v1.x.x PR]
    D --> L
    I --> L
    K --> L
Loading

Last reviewed commit: 9e70a3f

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the local release-please-config.json to ensure it accurately reflects the intended versioning strategy and changelog structure. The primary goal is to prevent incorrect major version bumps by aligning the local configuration with the central settings, thereby making the local config a reliable source of truth for release management.

Highlights

  • Versioning Strategy: Replaced the deprecated bump-minor-pre-major: true configuration with the modern versioning: always-bump-minor setting in release-please-config.json.
  • Changelog Configuration: Added a breaking changelog section to align with the central configuration and adjusted the ordering of existing changelog-sections for consistency.
Changelog
  • release-please-config.json
    • Replaced the deprecated bump-minor-pre-major flag with versioning: always-bump-minor.
    • Added a new breaking section to the changelog-sections array.
    • Reordered the changelog-sections to match the established central configuration.
Activity
  • PR chore(main): release 2.0.0 #86 (chore(main): release 2.0.0) was generated due to an incorrect interpretation of a BREAKING CHANGE footer.
  • PR chore(main): release 2.0.0 #86 has been closed and the release-please--branches--main branch deleted to force recalculation.
  • After this PR merges, release-please is expected to create a correct v1.x.x PR.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the release-please configuration by replacing the deprecated bump-minor-pre-major flag with the modern versioning: always-bump-minor strategy. This change ensures that breaking changes will result in a minor version bump, aligning with the intended versioning policy. The adjustments to changelog-sections also bring the configuration in line with a central standard. I have one suggestion to improve the readability of the generated changelogs.

Note: Security Review has been skipped due to the limited scope of the PR.

@JacobPEvans JacobPEvans merged commit d8a1670 into main Mar 6, 2026
21 checks passed
@JacobPEvans JacobPEvans deleted the fix/prevent-major-releases branch March 6, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants