fix(release): replace bump-minor-pre-major with versioning always-bump-minor#89
Conversation
…p-minor Switch from the deprecated bump-minor-pre-major flag to the explicit versioning: always-bump-minor strategy. This ensures major version bumps (from BREAKING CHANGE commits) are always capped at minor regardless of commit type. Also adds the 'breaking' changelog section. Relates to: stale v2.0.0 release-please PR #86, now closed. (claude)
|
Claude finished @JacobPEvans's task in 41s —— View job PR Review: fix(release): replace bump-minor-pre-major with versioning always-bump-minor
The change is correct and well-motivated. No blocking issues.
Ordering fix — Correct, and consistent with central config. Overall: LGTM. The fix directly addresses the root cause of the spurious v2.0.0 PR. |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s local Release Please configuration to match the current release strategy and central configuration expectations, reducing confusion and preventing unintended major bumps while still pre-1.0.
Changes:
- Replaces deprecated
bump-minor-pre-majorwithversioning: always-bump-minor. - Adds a
breakingchangelog section. - Reorders
changelog-sectionsentries to align with the central configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR updates Key changes:
This single-file change is safe to merge. The configuration now correctly reflects the release strategy and will prevent the false v2.0.0 bump that occurred in PR #86. Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Commit lands on main] --> B{Commit type?}
B -- "feat: ..." --> C[Minor bump]
B -- "fix: / perf: ..." --> D[Patch bump]
B -- "feat!: ... OR BREAKING CHANGE footer" --> E{versioning strategy?}
B -- "chore: / ci: / docs: / refactor: / test: ..." --> F[No version bump\nhidden in changelog]
B -- "breaking: ..." --> G[Patch bump\nvisible in Breaking Changes section]
E -- "bump-minor-pre-major: true\n(old / deprecated)" --> H{Is version < 1.0.0?}
H -- yes --> I[Minor bump]
H -- no --> J[Major bump ⚠️]
E -- "versioning: always-bump-minor\n(new / this PR)" --> K[Always Minor bump\nregardless of version]
C --> L[release-please opens v1.x.x PR]
D --> L
I --> L
K --> L
Last reviewed commit: 9e70a3f |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the local Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the release-please configuration by replacing the deprecated bump-minor-pre-major flag with the modern versioning: always-bump-minor strategy. This change ensures that breaking changes will result in a minor version bump, aligning with the intended versioning policy. The adjustments to changelog-sections also bring the configuration in line with a central standard. I have one suggestion to improve the readability of the generated changelogs.
Note: Security Review has been skipped due to the limited scope of the PR.
Summary
bump-minor-pre-major: truewithversioning: always-bump-minorbreakingchangelog section (consistent with central config)changelog-sectionsto match central configContext
PR #86 (
chore(main): release 2.0.0) was generated because release-please interpreted aBREAKING CHANGEfooter in a commit as requiring a major bump. The reusable workflow injectsversioning: always-bump-minorfrom the central config at runtime, but the local config was stale and causing confusion.This update:
versioninginstead of the deprecated flagPR #86 has been closed and the
release-please--branches--mainbranch deleted to force recalculation. After this merges, release-please will create a correct v1.x.x PR.Test plan
🤖 Generated with Claude Code