Open
Conversation
…mp/workstation into s3-support-no-preload-patch
Contributor
Let me know if there is more specific testing that would be useful. |
Collaborator
|
Just double-checking the commit for 6af37e7, did you basically just move the prefetching logic to only start working if the SharedVolume is loaded (3D view is started)? I don't see the commit for restraining the 2D unless the 2D view is loaded. Which commit would it be in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch that would no start preloading tiles as soon as the Horta Control panel is open. Currently it starts pre-loading 2-D tiles even though we currently use it only for 3-D tiles. The patch is hacky and I don't know if it may break or not anything so please review it carefully. I tested it on my dev workstation and it seems to work. I am in no rush to merge this PR but if it works it can be a good optimization.