Fix Starlette 1.0.0 TemplateResponse API and Windows test issues#18
Open
mkitti wants to merge 1 commit intoJaneliaSciComp:mainfrom
Open
Fix Starlette 1.0.0 TemplateResponse API and Windows test issues#18mkitti wants to merge 1 commit intoJaneliaSciComp:mainfrom
mkitti wants to merge 1 commit intoJaneliaSciComp:mainfrom
Conversation
- Update TemplateResponse calls to new Starlette 1.0.0 signature:
(request, name, context=...) instead of (name, {"request": ...})
- Guard MB/s print against ZeroDivisionError when elapsed time is 0
- Wrap file handles in `with` statements in test_range_request_buffering
so they are closed before unlink() (required on Windows)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withstatements in test_range_request_buffering so they are closed before unlink() (required on Windows)