feat: user delete backend by csiyang · Pull Request #8878 · JesusFilm/core

csiyang · 2026-03-19T01:51:11Z

Add user deletion endpoints with interop pattern:

api-users: userDeleteCheck mutation, userDeleteConfirm subscription
api-journeys-modern: interop mutations for journeys data cleanup
Firebase-only account deletion support
Audit logging for all deletions
Comprehensive test coverage

Summary by CodeRabbit

New Features
- User deletion workflow: pre-check summary, confirm execution, and real-time progress updates with streamed operation logs.
- Automatic handling of associated journeys and teams with ownership transfer where applicable.
- Delete users by database ID or email, with audit records persisted for traceability.
- Safeguards and detailed logs to surface issues during deletion.
Chores
- Adjusted supported messaging platform options.

linear · 2026-03-19T01:51:16Z

NES-1454 deleteUser backend

coderabbitai · 2026-03-19T01:51:19Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds a cross-service user-deletion workflow: gateway schema additions, journeys-side evaluation & deletion services, users-side lookup/firebase/db deletion and subscription orchestration, Prisma audit-log model + migration, inter-service Apollo calls, and unit tests across services.

Changes

Cohort / File(s)	Summary
API Gateway Schema `apis/api-gateway/schema.graphql`	Added user-delete mutations and subscription fields, new result/log types, and `UserDeleteIdType`.
API Journeys Modern — schema & registration `apis/api-journeys-modern/schema.graphql`, `apis/api-journeys-modern/src/schema/schema.ts`, `apis/api-journeys-modern/src/schema/userDelete/index.ts`	Registered new user-delete schema modules; removed `discord`, `signal`, `weChat` from `MessagePlatform` enum.
API Journeys Modern — services & types `apis/api-journeys-modern/src/schema/userDelete/service/*`, `.../userDelete/types.ts`	Added `checkJourneysData` and `deleteJourneysData` with Log types, transaction ownership-transfer logic, cascading deletes, and unit tests.
API Journeys Modern — GraphQL modules `apis/api-journeys-modern/src/schema/userDelete/userDeleteJourneysCheck.ts`, `.../userDeleteJourneysConfirm.ts`	Added GraphQL object types and mutations `userDeleteJourneysCheck` and `userDeleteJourneysConfirm` wired to services and auth rules.
API Users — schema, builder & registration `apis/api-users/schema.graphql`, `apis/api-users/src/schema/builder.ts`, `apis/api-users/src/schema/schema.ts`, `apis/api-users/src/schema/userDelete/index.ts`	Enabled subscription support, added `userDeleteCheck` mutation and `userDeleteConfirm` subscription, and registered userDelete modules.
API Users — services & types `apis/api-users/src/schema/userDelete/service/*`	Added `lookupUser`, `deleteFirebaseUser`, `deleteUserData`, `journeysInterop` (Apollo interop with timeout), logging utilities, barrels, and unit tests.
API Users — GraphQL resolvers & subscription `apis/api-users/src/schema/userDelete/userDeleteCheck.ts`, `apis/api-users/src/schema/userDelete/userDeleteConfirm.ts`	Added `userDeleteCheck` mutation and `userDeleteConfirm` subscription that stream progress logs and orchestrate lookup → journeys confirm → Firebase/db deletion → audit-log updates.
Database — Prisma model & migration `libs/prisma/users/db/schema.prisma`, `libs/prisma/users/db/migrations/.../migration.sql`, `libs/prisma/users/db/migrations/migration_lock.toml`	Added `UserDeleteAuditLog` Prisma model and migration SQL; minor migration_lock formatting tweak.
Infrastructure `apis/api-users/infrastructure/locals.tf`	Added `GATEWAY_URL` to environment variables list.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant APIUsers as API Users
    participant APIJourneys as API Journeys Modern
    participant PrismaDB as Prisma Database
    participant FirebaseAuth as Firebase Auth

    Client->>APIUsers: userDeleteCheck(idType,id)
    APIUsers->>PrismaDB: lookup user by id/email
    PrismaDB-->>APIUsers: user record or null
    APIUsers->>FirebaseAuth: check Firebase existence/uid
    FirebaseAuth-->>APIUsers: firebase metadata
    APIUsers->>APIJourneys: callJourneysCheck(userId)
    APIJourneys->>PrismaDB: evaluate journeys/teams (counts)
    PrismaDB-->>APIJourneys: counts & logs
    APIJourneys-->>APIUsers: check result + logs
    APIUsers-->>Client: UserDeleteCheckResult + logs

    Client->>APIUsers: subscribe userDeleteConfirm(idType,id)
    APIUsers->>PrismaDB: lookup user & get caller
    APIUsers->>APIJourneys: callJourneysConfirm(userId)
    APIJourneys->>PrismaDB: transfer/delete journeys & cleanup
    APIJourneys-->>APIUsers: confirm result + logs
    APIUsers->>FirebaseAuth: deleteFirebaseUser(uid)
    FirebaseAuth-->>APIUsers: deletion logs/result
    APIUsers->>PrismaDB: create/update UserDeleteAuditLog and delete user row
    APIUsers-->>Client: streamed progress entries (log, done, success)

Estimated Code Review Effort

🎯 4 (Complex) | ⏱️ ~60 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'feat: user delete backend' clearly and concisely summarizes the main change—adding backend infrastructure for user deletion across multiple subgraphs with mutations, subscriptions, and supporting services.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch siyangcao/nes-1454-deleteuser-backend

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-19T01:52:14Z

	Warnings
⚠️	❗ Big PR (10802 changes)

(change count - 10802): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against aabd30f

nx-cloud · 2026-03-19T01:52:33Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit aabd30f

Command	Status	Duration	Result
`nx run journeys-e2e:e2e`	❌ Failed	4m 8s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-15 07:18:18 UTC

github-actions · 2026-03-19T01:55:00Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
journeys	✅ Ready	journeys preview	Wed Apr 15 18:05:22 NZST 2026

github-actions · 2026-03-19T01:55:06Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
short-links	✅ Ready	short-links preview	Wed Apr 15 18:04:23 NZST 2026

github-actions · 2026-03-19T01:55:06Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
player	✅ Ready	player preview	Wed Apr 15 18:04:58 NZST 2026

github-actions · 2026-03-19T01:55:39Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
videos-admin	✅ Ready	videos-admin preview	Wed Apr 15 18:05:42 NZST 2026

github-actions · 2026-03-19T01:56:11Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
watch	✅ Ready	watch preview	Wed Apr 15 18:05:59 NZST 2026

github-actions · 2026-03-19T01:56:19Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
resources	✅ Ready	resources preview	Wed Apr 15 18:06:08 NZST 2026

github-actions · 2026-03-19T02:03:10Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
journeys-admin	✅ Ready	journeys-admin preview	Wed Apr 15 18:07:16 NZST 2026

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

stage-branch-merger · 2026-04-15T03:53:57Z

I see you added the "on stage" label, I'll get this merged to the stage branch!

stage-branch-merger · 2026-04-15T03:54:15Z

Merge conflict attempting to merge this into stage. Please fix manually.

…rneys-modern schema (NES-1454) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

stage-branch-merger · 2026-04-15T03:58:36Z

Merge conflict attempting to merge this into stage. Please fix manually.

stage-branch-merger · 2026-04-15T03:59:54Z

Merge conflict attempting to merge this into stage. Please fix manually.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

stage-branch-merger · 2026-04-15T04:03:41Z

Merge conflict attempting to merge this into stage. Please fix manually.

…ckend' into siyangcao/nes-1454-deleteuser-backend

jesus-film-bot · 2026-04-15T04:04:16Z

Ran Plan for dir: infrastructure workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8969. To continue, delete the lock from #8969 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

github-actions · 2026-04-15T04:08:24Z

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
watch-modern	✅ Ready	watch-modern preview	Wed Apr 15 18:04:30 NZST 2026

… failures - Remove duplicate `isSuperAdmin: boolean` from AuthScopes interface (merge conflict artifact from stage merge — line 82 was the stale copy; the lazy `boolean | (() => Promise<boolean>)` on line 84 is correct) - Move `aria-label` on UserDelete TextField to `inputProps` so it reaches the actual <input> element rather than the outer FormControl div - Fix UserDelete spec assertions using `toHaveValue(expect.stringContaining(...))` which silently fails in jest-dom 6.5.0 (lodash isEqualWith doesn't handle jest asymmetric matchers); changed to `.value.toContain(...)` instead Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jesus-film-bot · 2026-04-15T04:56:52Z

Ran Plan for dir: infrastructure workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8969. To continue, delete the lock from #8969 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

…NES-1454) - Add migration 20260415000000 to ADD deletedUserFirebaseUid and completedAt columns to UserDeleteAuditLog on existing DBs — these fields were added to the Prisma schema but had no corresponding SQL migration, so they would be missing on any DB that had already run the earlier migrations - Add self-deletion test to deleteUserData.spec.ts: verifies the audit log is created BEFORE user.delete() and that callerEmail is stored, so the log is useful even after the user record is removed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jesus-film-bot · 2026-04-15T05:25:21Z

Ran Plan for dir: infrastructure workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8969. To continue, delete the lock from #8969 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

…S-1454) TS2339 type-check failure — getByRole returns HTMLElement which does not have a .value property; cast to HTMLTextAreaElement (the actual rendered element from MUI TextField multiline) at the three affected assertions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jesus-film-bot · 2026-04-15T05:35:44Z

Ran Plan for dir: infrastructure workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8969. To continue, delete the lock from #8969 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

Three ESLint errors blocking journeys-admin:lint: - import/order: move CircularProgress after Button (alphabetical MUI order) in UserDelete.tsx - import/order: move GET_ME import before UserDelete import in pages/users/delete.tsx - no-void (x2): wrap `void handleCheck()` and `void handleConfirmDelete()` in block bodies per allowAsStatement:true rule config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jesus-film-bot · 2026-04-15T05:56:21Z

Ran Plan for dir: infrastructure workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8969. To continue, delete the lock from #8969 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

jesus-film-bot · 2026-04-15T06:00:29Z

Ran Plan for dir: infrastructure workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8969. To continue, delete the lock from #8969 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

blacksmith-sh · 2026-04-15T06:13:43Z

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
`src/e2e/journeys.spec.ts/journeys`	View Logs

csiyang self-assigned this Mar 19, 2026

github-actions Bot temporarily deployed to Preview - videos-admin March 19, 2026 01:52 Inactive

github-actions Bot temporarily deployed to Preview - short-links March 19, 2026 01:52 Inactive

github-actions Bot temporarily deployed to Preview - player March 19, 2026 01:52 Inactive

github-actions Bot temporarily deployed to Preview - watch March 19, 2026 01:52 Inactive

github-actions Bot requested a deployment to Preview - journeys-admin March 19, 2026 01:52 Pending

github-actions Bot temporarily deployed to Preview - journeys March 19, 2026 01:52 Inactive

github-actions Bot temporarily deployed to Preview - resources March 19, 2026 01:52 Inactive

github-actions Bot temporarily deployed to Preview - journeys March 19, 2026 01:59 Inactive

github-actions Bot temporarily deployed to Preview - journeys-admin March 19, 2026 01:59 Inactive

github-actions Bot temporarily deployed to Preview - videos-admin March 19, 2026 01:59 Inactive

github-actions Bot temporarily deployed to Preview - short-links March 19, 2026 01:59 Inactive

github-actions Bot temporarily deployed to Preview - resources March 19, 2026 01:59 Inactive

github-actions Bot temporarily deployed to Preview - watch March 19, 2026 01:59 Inactive

github-actions Bot temporarily deployed to Preview - player March 19, 2026 01:59 Inactive

github-actions Bot temporarily deployed to Preview - player March 19, 2026 02:24 Inactive

github-actions Bot temporarily deployed to Preview - journeys March 19, 2026 02:24 Inactive

github-actions Bot temporarily deployed to Preview - journeys-admin March 19, 2026 02:24 Inactive

github-actions Bot temporarily deployed to Preview - short-links March 19, 2026 02:24 Inactive

csiyang and others added 2 commits April 15, 2026 15:07

chore: add eslint.config.mjs to shared-user-delete lib (NES-1454)

c196f20

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: lint issues

68cd935

This comment has been minimized.

Sign in to view

Merge branch 'main' into siyangcao/nes-1454-deleteuser-backend

5da2dea

fix: restore discord/signal/weChat to MessagePlatform enum in api-jou…

7ca5148

…rneys-modern schema (NES-1454) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: graphql generate

100dc42

autofix-ci Bot and others added 2 commits April 15, 2026 04:02

fix: lint issues

2e56c6c

chore: merge origin/stage into nes-1454-deleteuser-backend

1f0c6e1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/siyangcao/nes-1454-deleteuser-ba…

45fe03f

…ckend' into siyangcao/nes-1454-deleteuser-backend

This comment has been minimized.

Sign in to view

fix: lint issues

aabd30f

mikeallisonJS approved these changes Apr 15, 2026

View reviewed changes

csiyang mentioned this pull request Apr 20, 2026

revert: remove piggybacked #8875 and #8969 from squash 82d63a110 #9044

Merged

4 tasks

Conversation

csiyang commented Mar 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Estimated Code Review Effort

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

stage-branch-merger Bot commented Apr 15, 2026

Uh oh!

stage-branch-merger Bot commented Apr 15, 2026

Uh oh!

stage-branch-merger Bot commented Apr 15, 2026

Uh oh!

stage-branch-merger Bot commented Apr 15, 2026

Uh oh!

stage-branch-merger Bot commented Apr 15, 2026

Uh oh!

jesus-film-bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesus-film-bot commented Apr 15, 2026

Uh oh!

This comment has been minimized.

jesus-film-bot commented Apr 15, 2026

Uh oh!

jesus-film-bot commented Apr 15, 2026

Uh oh!

jesus-film-bot commented Apr 15, 2026

Uh oh!

jesus-film-bot commented Apr 15, 2026

Uh oh!

blacksmith-sh Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failure

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

csiyang commented Mar 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

nx-cloud Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Apr 15, 2026 •

edited

Loading

blacksmith-sh Bot commented Apr 15, 2026 •

edited

Loading