Emit "connection" event on server when a socket connects#14
Open
sisou wants to merge 1 commit intoJohanWinther:masterfrom
Open
Emit "connection" event on server when a socket connects#14sisou wants to merge 1 commit intoJohanWinther:masterfrom
sisou wants to merge 1 commit intoJohanWinther:masterfrom
Conversation
Owner
I have an idea to add an Do you think that is a good idea? |
Collaborator
Author
|
Jup, I agree, will update this PR. |
97ff3f1 to
5500a53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Adds server-side 'connection' event on socket connection (I hope that's obvious 😄). This also exposes the
requestin all event payloads, I don't know if that is required, necessary or even wanted? Might be helpful to check for custom headers in a server implementation on certain message events?