propagate first and last for OffsetRanges#258
Draft
jishnub wants to merge 1 commit intoJuliaArrays:masterfrom
Draft
propagate first and last for OffsetRanges#258jishnub wants to merge 1 commit intoJuliaArrays:masterfrom
jishnub wants to merge 1 commit intoJuliaArrays:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 5 5
Lines 436 436
=======================================
Hits 416 416
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate
firstandlastto the parent forOffsetArray(::AbstractRange). On masterstepwas propagated anyway as this is not defined for abstractarrays in general. The current change is an optimization as it gets around the need to index into the array to find the first element.The
firstandlastelements for ranges are often obtained by explicitly accessing fields, so I don't think that it's possible to obtain these for wrapper types by using traits.I'm not sure if this provides an immediate real-world performance benefit, so perhaps we may leave this open for now. I had created this keeping something like JuliaLang/julia#41945 in mind. If
iterateuses traits then we may require a rapid evaluation offirstandlastelements forOffsetRanges to be as performant as ranges.