Add isonebased trait to opt out of OffsetArray wrappers#335
Open
jishnub wants to merge 3 commits intoJuliaArrays:masterfrom
Open
Add isonebased trait to opt out of OffsetArray wrappers#335jishnub wants to merge 3 commits intoJuliaArrays:masterfrom
isonebased trait to opt out of OffsetArray wrappers#335jishnub wants to merge 3 commits intoJuliaArrays:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 98.67% 98.69% +0.02%
==========================================
Files 5 5
Lines 452 459 +7
==========================================
+ Hits 446 453 +7
Misses 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
isonebased trait to opt-out of OffsetArray wrappersisonebased trait to opt out of OffsetArray wrappers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is
Also, in this case, the
similarmethod in this package will forward the lengths of the axes toBase, so the result will usually be anArrayinstead of anOffsetArray: