Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 55.05% 55.10% +0.04%
==========================================
Files 28 28
Lines 2810 2813 +3
==========================================
+ Hits 1547 1550 +3
Misses 1263 1263
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a high priority, and I am not sure if we want to do this.
Hopefully it is zero overhead by I am yet to check.
I found a case in the wild where I had screwed this up, by putting a
ZeroTangentsomewhere that should have gotten aZeroTangent().It's possible to screw this up both in Diffractor itself, but also in rule definitions. (though CRTU.jl will protect against the later)
It is nice to error as close to the creation of the bad type as possible to help work out what is triggering it