Open
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 56.17% 56.19% +0.01%
==========================================
Files 28 28
Lines 2848 2849 +1
==========================================
+ Hits 1600 1601 +1
Misses 1248 1248
☔ View full report in Codecov by Sentry. |
Member
Author
|
@Keno could you give this a review, and see if you think of a better way? |
3 tasks
Collaborator
|
@Keno review please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diffractor was having a bit of a sad because
(Int,)has typeTuple{DataType}but the primal
Bhas typeTuple{Type{Int}},and while they are logically the same apparently dispatch does not like that.
The solution right now in this PR is to throw away that extra info we have about
Band normalize it to justTyple{DataType}.idk if it is best, I am open to other ideas.