[WIP] handle higher order binary ops of mixed types#272
Draft
[WIP] handle higher order binary ops of mixed types#272
Conversation
This was referenced Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the test.
This is a MWE of something that occurs in the wild with Diffractor over ForwardDiff.
Apparently we are ADing a call to
-(::Dual, ::Float64)The change in this PR to make the special Diffractor only rules not allow this is correct.
However, this still failed because ChainRules.jl has the same rules.
So perhaps ChainRules.jl also needs a change to not do this.
(Or maybe ChainRulesCore to redefine the
@scalar_rulemacro so it only ever works on things of the same type)