Implement continuing processing on error#233
Implement continuing processing on error#233Kolaru wants to merge 7 commits intoJuliaIntervals:masterfrom
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
|
this looks good to me. |
|
@OlivierHnt The more I think about it, the more I think only the errors coming from IntervalArithmetic.jl really have a chance to be relevant here. So I would put this on hold, until one of us implement the new error type there. What do you think? On a side note, there are more changes that necessary, because I also spent some time fixing the doctests while I was at it, even so it is not the core of this PR. |
|
Sounds good, it's better to properly resolve the issue instead of making a temporary "hotfix". |
| often leading to having a solution directly on the boundary of a region, | ||
| which prevent the contractor to prove it's unicity. Default: `127/256`. | ||
| -`bisect_on_error`: Whether a region that errors when the function is applied to | ||
| to it should be bisected. If false, when an error happen, the root search is |
There was a problem hiding this comment.
Looks like there is a typo "to" is repeated twice
|
I am wondering if the default should be |
Fix #232
By default, with this PR, errors are ignored, and the corresponding regions are bisected further, in the hope that by reducing them, the error will go away.
This can be disable by setting the new option
bisect_on_errorto false.Whether an error occurred, and why does a root stop being processed are both stored in the Root object, which allows to give more information at the end of the root search.
With this PR, the following works:
Resulting in
Doc and tests are missing and will come soon.
@brianguenter Does it look like a fine solution to your issue?