Conversation
There was a problem hiding this comment.
Pull request overview
This PR relocates the aircrfta problem’s provenance/licensing documentation from the PureJuMP implementation file into the corresponding Meta dictionary.
Changes:
- Removed the large header comment block from
src/PureJuMP/aircrfta.jl. - Added
:url,:notes,:origin_notes, and:referenceentries tosrc/Meta/aircrfta.jl.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/PureJuMP/aircrfta.jl | Removes the embedded provenance/license header from the problem implementation file. |
| src/Meta/aircrfta.jl | Stores the removed provenance/license information (plus URL/reference) in the problem’s metadata dict. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export aircrfta | ||
|
|
||
| function aircrfta(; n::Int = default_nvar, kwargs...) |
There was a problem hiding this comment.
The upstream license/permission text that was previously embedded in this source file has been removed. Since the permission grant explicitly requires the copyright/permission notice to appear in all copies, keeping the notice only in a separate Meta file may not satisfy that requirement (and is inconsistent with other PureJuMP problem files that retain this header). Consider restoring a minimal copyright/permission header in this file (or otherwise ensuring the notice is included with this source when distributed).
| :url => "https://www.osti.gov/biblio/6449249", | ||
| :notes => raw""" | ||
| Converted in Julia from https://github.com/mpf/Optimization-Test-Problems | ||
|
|
||
| AMPL Model by Hande Y. Benson |
There was a problem hiding this comment.
The newly added :url, :notes, :origin_notes, and :reference keys are not part of the aggregated OptimizationProblems.meta DataFrame (which only copies a fixed list of keys). If these fields are meant to be discoverable via the standard metadata interface, consider extending cols_names/types and the DataFrame population logic (or adding a documented accessor) so users can query them without reaching into aircrfta_meta directly.
No description provided.