Add hs85 and hs89 problems#412
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
===========================================
- Coverage 99.80% 54.63% -45.17%
===========================================
Files 1084 1144 +60
Lines 12319 13639 +1320
===========================================
- Hits 12295 7452 -4843
- Misses 24 6187 +6163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| header_ok = false | ||
| if result["ADNLP"] | ||
| header = readlines("src/ADNLPProblems/$problem.jl")[1:10] | ||
| header_ok = any(occursin("Hock and Schittkowski", h) for h in header) | ||
| end | ||
| result["Header"] = header_ok |
There was a problem hiding this comment.
I am not sure to understand what you are checking here ?
There was a problem hiding this comment.
This code checks if the first 10 lines (the "header") of the src/ADNLPProblems/$problem.jl file mention "Hock and Schittkowski" for proper documentation of source. Once you commit, will change it to meta, kept adnlp as placeholder for now.
docs/check_rules.jl
Outdated
| header_ok = any(occursin("Hock and Schittkowski", h) for h in header) | ||
| end | ||
| result["Header"] = header_ok | ||
| # Bounds/x0 |
There was a problem hiding this comment.
Make for each test, can you make a more complete sentence?
| # Script to check OptimizationProblems.jl rules for HS85/HS89 | ||
| using JSON | ||
|
|
||
| function check_problem(problem::String) |
2 participants
@dpo @tmigot
Towards #113