Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
KWASM_DIRvalue configurable via env varscontainerd/runwasiruntimes tov0.4.0$PATHto discover thesystemctlbinary locationThe motivation of this PR is to make the script also able to provision GKE nodes using the
cos_containerdimage. Such image has many partitions mounted withroornoexecor both. For example, the default/opt/kwasmdir would land onso the dir could never be created. However there are other partitions where users can read and execute. This PR adds the ability to pass in a custom
KWASM_DIRvalue where things will be installed in the hosts.I'm also bumping some versions to the latest release and also relying on the
$PATHenv var to discover thesystemctllocation rather than passing a full path. Turns out in nodes runningcos_containerdthe binary lives in/usr/bin/systemctl. In this decision I'm assuming$PATHis always correctly set in RKE and any other K8s distribution. I think it's a pretty safe assumption to make but happy to code a specific GKE case if needed.