Open
Conversation
Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>
Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>
Anton-Soroka
requested changes
Mar 27, 2021
Anton-Soroka
left a comment
There was a problem hiding this comment.
Please fix according to comments.
Comment on lines
+34
to
+38
| / # cat sys/bus/i2c/devices/0-0050/eeprom | hexdump -C | ||
| 00000000 aa 55 33 ee 41 33 33 35 42 4e 4c 54 30 30 43 30 |.U3.A335BNLT00C0| | ||
| 00000010 32 34 31 39 42 42 42 4b 30 31 42 42 ff ff ff ff |2419BBBK01BB....| | ||
| 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| | ||
| * |
There was a problem hiding this comment.
According to task description:
- you should use EEPROM on additional board - i2c2 bus
- you should make change to devicetree to override EEPROM model to the one that you use
Author
There was a problem hiding this comment.
I don't have the same RTC as in the task that is why I have task with BeagleBone EEPROM
Comment on lines
+6
to
+14
| Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com> | ||
| --- | ||
| 09_dt_rtc/README.md | Bin 0 -> 4065 bytes | ||
| 09_dt_rtc/log.txt | Bin 0 -> 7948 bytes | ||
| scissors/README.md | Bin 481 -> 0 bytes | ||
| 3 files changed, 0 insertions(+), 0 deletions(-) | ||
| create mode 100644 09_dt_rtc/README.md | ||
| create mode 100644 09_dt_rtc/log.txt | ||
| delete mode 100644 scissors/README.md |
There was a problem hiding this comment.
Please provide correct patch for devicetree.
It should be human readable.
No binary data here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task09 Done