Task5 by ant112342 · Pull Request #152 · Kernel-GL-HRK/gl-kernel-training-2021

ant112342 · 2021-03-25T15:48:16Z

Done task05

Implemented proc and sys convering word into uppercase and lower case Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>

05_debug/task05_proc.c

05_debug/task05_sys.c

alexposukhov · 2021-03-25T20:10:17Z

05_debug/task05_sys.c

+		return -EINVAL;
+	}
+
+	res = class_create_file(x_class, &class_attr_total_characters_processed);


Checkpatch complains on this line as too long. Please split it.

alexposukhov · 2021-03-25T20:10:48Z

05_debug/task05_sys.c

+	class_remove_file(x_class, &class_attr_xxx);
+	class_destroy(x_class);
+
+	return;


Remove this return, remove then empty line

Have minor comments, all other works for me

Performed refactoring of existed code Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>

Anton-Soroka · 2021-03-27T16:28:52Z

README.md



 Please refer to wiki for details.
+=======


This file should NOT be modified.

This is in YOUR pull request, so it somehow happened, probably by mistake.
Now you need to remove this extra change.
In order to do it - you have to inspect all your commits and find the problematic one.
Then do interactive rebase with stop on the problematic commit and fix it.

Anton-Soroka

Sorry, I can't check your task without Makefile
Please do following:

Add Makefile
Cherry-pick commit with task description
Remove modifications in README file
Fix code according to comments
Ensure that make and checkpatch shows zero warnings.

Anton-Soroka · 2021-03-27T16:40:44Z

05_debug/task05_sys.c

+		pr_err("bad file 'total_characters_processed' create\n");
+		return -EINVAL;
+	}
+
+	res = class_create_file(x_class, &class_attr_total_calls);
+	if (res != 0) {
+		pr_err("bad file 'total_calls' create\n");
+		return -EINVAL;
+	}
+
+	res = class_create_file(x_class, &class_attr_characters_converted);
+	if (res != 0) {
+		pr_err("bad file 'characters_converted' create\n");
+		return -EINVAL;


In case of error - Need to destroy previously created files and classes.

Done, but I think README was changed, because previous this branch was deleted
I don't know why

Still not done :(
Please read previous comment carefully!

05_debug/task05_proc.c

Anton-Soroka · 2021-03-28T19:22:01Z

05_debug/Makefile

+else
+# normal makefile
+
+obj-m   := task05_sys.o


You have two modules in this task.
Need to do following: either add line for second module here or add a separate makefile for each module.

Anton-Soroka

Previous comments still not resolved.
Please read carefully.

Implemented Makefile and added it to task05. Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>

ant112342 requested a review from alexposukhov March 25, 2021 15:48

kernel: Added code for task05

da45215

Implemented proc and sys convering word into uppercase and lower case Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>

ant112342 force-pushed the task5 branch from 939ea02 to a996ccb Compare March 25, 2021 15:54

ant112342 added the Ready for review Ready for review label Mar 25, 2021

ant112342 force-pushed the task5 branch from a996ccb to 26f1eac Compare March 25, 2021 17:21

alexposukhov requested changes Mar 25, 2021

View reviewed changes

alexposukhov added Change requested Change requested and removed Ready for review Ready for review labels Mar 25, 2021

kernel: Modify proc and sysfs code

c680cf3

Performed refactoring of existed code Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>

ant112342 force-pushed the task5 branch from 26f1eac to c680cf3 Compare March 25, 2021 20:34

ant112342 added Ready for review Ready for review and removed Change requested Change requested labels Mar 25, 2021

Anton-Soroka reviewed Mar 27, 2021

View reviewed changes

Anton-Soroka requested changes Mar 27, 2021

View reviewed changes

Anton-Soroka added Change requested Change requested and removed Ready for review Ready for review labels Mar 27, 2021

ant112342 added Ready for review Ready for review and removed Change requested Change requested labels Mar 28, 2021

Anton-Soroka reviewed Mar 28, 2021

View reviewed changes

Anton-Soroka requested changes Mar 28, 2021

View reviewed changes

Anton-Soroka added Change requested Change requested and removed Ready for review Ready for review labels Mar 28, 2021

kernel: Add Makefile to task05

7cf02ec

Implemented Makefile and added it to task05. Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>

ant112342 force-pushed the task5 branch from 942f869 to 7cf02ec Compare March 28, 2021 20:44

ant112342 added Ready for review Ready for review and removed Change requested Change requested labels Mar 28, 2021

Conversation

ant112342 commented Mar 25, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Anton-Soroka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Anton-Soroka Mar 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Anton-Soroka left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Anton-Soroka left a comment •

edited

Loading

Anton-Soroka Mar 28, 2021 •

edited

Loading