Simple script to detect connected hardware#20
Open
sopa40 wants to merge 3 commits intoKernel-GL-HRK:nazar.sopihafrom
Open
Simple script to detect connected hardware#20sopa40 wants to merge 3 commits intoKernel-GL-HRK:nazar.sopihafrom
sopa40 wants to merge 3 commits intoKernel-GL-HRK:nazar.sopihafrom
Conversation
Signed-off-by: Nazar Sopiha <nazar.sopiha@gmail.com>
It is now detecting i2c (not via checking but just via ls command, don't know why function gets an error). Then script goes into an infinite cycle - for further decetions of plugged and unplugged hardware Signed-off-by: Nazar Sopiha <nazar.sopiha@gmail.com>
sopa40
added
question
ReAlUA
added
Change requested
It is now detecting i2c and flash connected devices Then script goes into an infinite cycle - for further decetions of hot plugged and unplugged hardware Signed-off-by: Nazar Sopiha <nazar.sopiha@gmail.com>
sopa40
added
Ready for review
ReAlUA
reviewed
Feb 19, 2021
|
|
||
| while true | ||
| do | ||
| echo "Detecting plugged and unplugged hardware. TBD" |
Contributor
There was a problem hiding this comment.
Are you going to continue working on this script?
Author
There was a problem hiding this comment.
I have made changes to the current version and functionality (i2c + flash and no real time detection, commit d0a1332). If they are ok, I would suggest to merge this patch for now.
I will come back and extend functionality when I have more time, but I see it as another patch.
If you insist on working more on this topic, I will change my priorities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script has very limited functionality. Please check the commit descriptions. Part of code to detect i2c does not work properly, that is why it is implemented but in a worse style. Deadline came, no time to improve atm.