Opokornyi by opokornyi · Pull Request #126 · Kernel-GL-HRK/gl_kernel_procamp_2021

opokornyi · 2021-12-14T10:27:07Z

01_git, 03_module are done

ziod · 2021-12-14T13:17:18Z

01_git/scissors.c

+    {
+        printf("\nYou chose %c and I choose %c, You win !\n\n", input_from_user, machine_chose);
+    }
+}


ziod · 2021-12-14T13:19:45Z

03_module/hello.c

+MODULE_LICENSE("GPL");
+
+module_init(hello_init);
+module_exit(hello_exit);


ziod · 2021-12-14T13:20:05Z

01_git/scissors.c

@@ -0,0 +1,68 @@
+#include <stdio.h>
+#include <stdlib.h>
+#include<time.h>


#include <time.h>

ziod · 2021-12-14T13:21:04Z

01_git/scissors.c

+
+const char arr[3] = {'r', 'p', 's'};
+
+int machine_rand(void) {


optional size might be reduced to uint8_t

01_git/scissors.c

ziod · 2021-12-14T13:30:17Z

01_git/scissors.c

+#include <stdlib.h>
+#include<time.h>
+
+const char arr[3] = {'r', 'p', 's'};


static const char ROCK = 'r';
static const char PAPER = 'p';
static const char SCISSORS = 's';

static const char arr[3] = {ROCK, PAPER, SCISSORS};

ziod · 2021-12-14T13:30:48Z

01_git/scissors.c

+    {
+        result = -1;
+    }
+    else if (input_user == 'r' && arr[machine_choice_int] == 's')


ROCK ... SCISSORS

ziod · 2021-12-14T13:34:19Z

03_module/hello.c

+#include <linux/init.h>
+#include <linux/kernel.h>
+
+int a = 0; 


may be static

ziod · 2021-12-14T14:44:20Z

03_module/hello.c

+MODULE_LICENSE("GPL");
+
+module_init(hello_init);
+module_exit(hello_exit);


WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1: FILE: /air/Documents/trainings/linux/kernel/pro-camp/2021/03_module/hello.c:1:
+#include <linux/module.h>

ERROR: trailing whitespace
#6: FILE: /air/Documents/trainings/linux/kernel/pro-camp/2021/03_module/hello.c:6:
+int a = 0; $

ERROR: do not initialise globals to 0
#6: FILE: /air/Documents/trainings/linux/kernel/pro-camp/2021/03_module/hello.c:6:
+int a = 0;

ERROR: do not initialise globals to 0
#7: FILE: /air/Documents/trainings/linux/kernel/pro-camp/2021/03_module/hello.c:7:
+int b = 0;

WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
#14: FILE: /air/Documents/trainings/linux/kernel/pro-camp/2021/03_module/hello.c:14:

printk(KERN_WARNING "\na + b = %i\n", a + b);

WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
#20: FILE: /air/Documents/trainings/linux/kernel/pro-camp/2021/03_module/hello.c:20:

printk(KERN_WARNING "\na - b = %i\n", (a < b)?(b - a):(a - b));

WARNING: adding a line without newline at end of file
#27: FILE: /air/Documents/trainings/linux/kernel/pro-camp/2021/03_module/hello.c:27:
+module_exit(hello_exit);

ziod · 2021-12-20T13:21:02Z

04_basic_struct/kobj.c

+	char *buf)
+{
+    struct msg_obj *curr_msg;
+    struct list_head * listptr;


Please use monilith code style

ziod · 2021-12-20T13:46:10Z

04_basic_struct/kobj.c

+        len += strlen(curr_msg->data);
+    }
+
+    return len;


strlen(buf)

ziod · 2021-12-20T13:52:46Z

04_basic_struct/kobj.c

+
+static void hello_exit(void)
+{
+


ziod · 2021-12-20T14:43:06Z

04_basic_struct/Makefile

+KERNELDIR ?= /home/oporoknyi/Desktop/build/buildroot-2021.02.7/output/build/linux-5.10.7 #WARNING relative path
+
+obj-m := kobj.o
+


ziod · 2021-12-23T13:42:32Z

02_bash/hwdetect

@@ -0,0 +1,64 @@
+# delete temporary files


ziod · 2021-12-23T13:47:02Z

02_bash/hwdetect

+  sleep  1
+# check if Ctrl-C pressed and exit
+  trap  'cleanup' INT
+done


…ous read of it, userspace application which returns absolute time in user space

ziod · 2021-12-28T08:29:35Z

05_timers/App/main.c

+	}
+	printf("\n");
+	return 0;
+}


ziod · 2021-12-28T08:30:00Z

05_timers/App/main.c

+	//switch off cursor
+	printf("\033[?25l");
+
+	while (1) {


please do not use endless loop

opokornyi requested a review from ziod December 14, 2021 10:27

opokornyi added the Ready for review label Dec 14, 2021

ziod requested changes Dec 14, 2021

View reviewed changes

opokornyi force-pushed the opokornyi branch from df3806d to 87a9a15 Compare December 16, 2021 12:11

ziod requested changes Dec 20, 2021

View reviewed changes

ziod reviewed Dec 20, 2021

View reviewed changes

ziod added Change requested change requested and removed Ready for review labels Dec 21, 2021

opokornyi force-pushed the opokornyi branch from aa5b117 to c45b213 Compare December 22, 2021 13:19

01_git/:Implement Scissors game

b7e558f

opokornyi force-pushed the opokornyi branch from c45b213 to 1d24967 Compare December 22, 2021 19:53

opokornyi added 3 commits December 22, 2021 23:19

02_bash/:Implemented Hardware detect program

8a05b55

03_module/: Implemented First Kernel Module

67de224

04_basic_struct: Implemented Kernel Module with object named "hello"

1d24967

opokornyi added Ready for review and removed Change requested change requested labels Dec 23, 2021

ziod requested changes Dec 23, 2021

View reviewed changes

05_timers/:Implemented module which returns relative time since previ…

9b90355

…ous read of it, userspace application which returns absolute time in user space

ziod requested changes Dec 28, 2021

View reviewed changes


		const char arr[3] = {'r', 'p', 's'};

		int machine_rand(void) {

		KERNELDIR ?= /home/oporoknyi/Desktop/build/buildroot-2021.02.7/output/build/linux-5.10.7 #WARNING relative path

		obj-m := kobj.o

Conversation

opokornyi commented Dec 14, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants