Skip to content

Fix #1477: Prevent scroll jump to top when resizing columns with row virtualization enabled #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daihua2 wants to merge 4 commits into
base: v3
Choose a base branch
from
+15 −11
Open

Fix #1477: Prevent scroll jump to top when resizing columns with row virtualization enabled #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
363af90
remove obsolete build tests
KevinVandy Sep 30, 2025
7abfa9b
remove obsolete build tests
KevinVandy Sep 30, 2025
f8c2639
Merge branch 'fix/1477-virtualization-scroll-resize' of https://githu…
daihua2 Mar 27, 2026
974fcde
Merge branch 'KevinVandy:v3' into fix/1477-virtualization-scroll-resize
daihua2 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/material-react-table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"dev": "pnpm lib:dev",
"lib:build": "pnpm build-lib && pnpm build-locales",
"lib:build-locales": "node build-locales.mjs",
"lib:build-lib": "rm -rf dist && rollup -c rollup.config.mjs && size-limit",
"lib:build-lib": "node -e \"require('fs').rmSync('dist',{recursive:true,force:true})\" && rollup -c rollup.config.mjs && size-limit",
"lib:dev": "rollup -c rollup.config.mjs --watch",
"lint": "eslint .",
"size": "size-limit",
Expand Down
2 changes: 1 addition & 1 deletion packages/material-react-table/src/components/head/MRT_TableHeadCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ export const MRT_TableHeadCell = <TData extends MRT_RowData>({
column={column}
table={table}
tableHeadCellRef={{
current: tableHeadCellRefs.current?.[column.id]!,
current: tableHeadCellRefs.current?.[column.id] ?? null,
}}
/>
)}
Expand Down
4 changes: 3 additions & 1 deletion packages/material-react-table/src/components/table/MRT_Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export const MRT_Table = <TData extends MRT_RowData>({
getState,
options: {
columns,
enableRowVirtualization,
enableStickyHeader,
enableTableFooter,
enableTableHead,
Expand Down Expand Up @@ -73,7 +74,8 @@ export const MRT_Table = <TData extends MRT_RowData>({
>
{!!Caption && <caption>{Caption}</caption>}
{enableTableHead && <MRT_TableHead {...commonTableGroupProps} />}
{memoMode === 'table-body' || columnSizingInfo.isResizingColumn ? (
{memoMode === 'table-body' ||
(columnSizingInfo.isResizingColumn && !enableRowVirtualization) ? (
<Memo_MRT_TableBody {...commonTableGroupProps} />
) : (
<MRT_TableBody {...commonTableGroupProps} />
Expand Down
12 changes: 7 additions & 5 deletions packages/material-react-table/src/hooks/useMRT_Effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,12 @@ export const useMRT_Effects = <TData extends MRT_RowData>(

//fix pinned row top style when density changes
useEffect(() => {
if (enableRowPinning && getIsSomeRowsPinned()) {
setTimeout(() => {
rerender();
}, 150);
}
if (!enableRowPinning || !getIsSomeRowsPinned()) return undefined;

const timeoutId = setTimeout(() => {
rerender();
}, 150);

return () => clearTimeout(timeoutId);
}, [density]);
};
6 changes: 3 additions & 3 deletions packages/material-react-table/src/hooks/useMRT_TableOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ export const useMRT_TableOptions: <TData extends MRT_RowData>(
mrtTheme = useMemo(() => getMRTTheme(mrtTheme, theme), [mrtTheme, theme]);
aggregationFns = useMemo(
() => ({ ...MRT_AggregationFns, ...aggregationFns }),
[],
[aggregationFns],
);
filterFns = useMemo(() => ({ ...MRT_FilterFns, ...filterFns }), []);
sortingFns = useMemo(() => ({ ...MRT_SortingFns, ...sortingFns }), []);
filterFns = useMemo(() => ({ ...MRT_FilterFns, ...filterFns }), [filterFns]);
sortingFns = useMemo(() => ({ ...MRT_SortingFns, ...sortingFns }), [sortingFns]);
defaultColumn = useMemo(
() => ({ ...MRT_DefaultColumn, ...defaultColumn }),
[defaultColumn],
Expand Down