Skip to content

fix: group row ID leaks into rowSelection when selecting grouped rows #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VC-Semih wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

fix: group row ID leaks into rowSelection when selecting grouped rows #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed14849
fix(selection): prevent group row ID from leaking into rowSelection w…
VC-Semih Mar 27, 2026
6471515
fix(selection): recalculate header checkbox state from leaf rows only…
VC-Semih Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/material-react-table/src/components/inputs/MRT_SelectCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,15 @@ export const MRT_SelectCheckbox = <TData extends MRT_RowData>({

const selectAll = !row;

const getLeafRows = () => (
selectAllMode === 'page'
? table.getPaginationRowModel().flatRows
: table.getPrePaginationRowModel().flatRows
).filter((r) => !r.getIsGrouped());

// Fix: getIsAllPageRowsSelected() / getIsAllRowsSelected() include group rows
const allRowsSelected = selectAll
? selectAllMode === 'page'
? table.getIsAllPageRowsSelected()
: table.getIsAllRowsSelected()
? getLeafRows().every((r) => r.getIsSelected())
: undefined;

const isChecked = selectAll
Expand Down Expand Up @@ -122,7 +127,8 @@ export const MRT_SelectCheckbox = <TData extends MRT_RowData>({
<Checkbox
indeterminate={
!isChecked && selectAll
? table.getIsSomeRowsSelected()
? // Fix: getIsSomeRowsSelected() includes group rows, use leaf-only filter
getLeafRows().some((r) => r.getIsSelected())
: row?.getIsSomeSelected() && row.getCanSelectSubRows()
}
{...commonProps}
Expand Down
24 changes: 21 additions & 3 deletions packages/material-react-table/src/utils/row.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,16 @@ export const getMRT_RowSelectionHandler =

const wasCurrentRowChecked = getIsRowSelected({ row, table });

// Fix: toggleSelected() on a group row also writes its own ID into rowSelection
// Removing it, keeping only the leaf row IDs
if (row.getIsGrouped()) {
table.setRowSelection((prev) => {
const next = { ...prev };
delete next[row.id];
return next;
});
}

// toggle selection of this row
row.toggleSelected(value ?? !wasCurrentRowChecked);

Expand Down Expand Up @@ -250,9 +260,17 @@ export const getMRT_SelectAllHandler =
refs: { lastSelectedRowId },
} = table;

selectAllMode === 'all' || forceAll
? table.toggleAllRowsSelected(value ?? (event as any).target.checked)
: table.toggleAllPageRowsSelected(value ?? (event as any).target.checked);
// Fix: replaces toggleAllPageRowsSelected() / toggleAllRowsSelected() which
// include group rows in flatRows, causing group IDs to pollute rowSelection.
const checked = value ?? (event as any).target.checked;
const rows = (selectAllMode === 'all' || forceAll
? table.getPrePaginationRowModel().flatRows
: table.getPaginationRowModel().flatRows
).filter((row) => !row.getIsGrouped());
rows.forEach((row) => {
if (row.getCanSelect()) row.toggleSelected(checked);
});

if (enableRowPinning && rowPinningDisplayMode?.includes('select')) {
table.setRowPinning({ bottom: [], top: [] });
}
Expand Down