Merged
Conversation
Add CertificateCleanupEnabled, TimeAfterExpiration, TimeAfterExpirationUnits, and DeleteWithArchivedKey to TemplatesTemplateRetrievalResponse and TemplatesTemplateUpdateRequest. Add CSSCMSDataModelEnumsCertificateCleanupTimeUnits enum (0=Days, 1=Weeks, 2=Months). Guard nullable field getters against nil pointer dereference when JSON null is present.
Add NullableInt32 Manageability field with getter/setter and ToMap entry to TemplatesTemplateRetrievalResponse in both v24 and v25 SDK packages. Field is read-only (v25+) and was present in JSON responses but missing from the Go struct, causing it to always deserialize as zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewAPIClientWithAuth()to accept anAuthConfiginterface for VCR-based integration testingCertificateCleanupTimeUnitsenum and cleanup-related fields onTemplateRetrievalResponseandTemplateUpdateRequestManageabilityfield toTemplateRetrievalResponsein both v24 and v25Changes
v24/client.goNewAPIClientWithAuth()for test injectionv24/api/keyfactor/v1/client.gov24/api/keyfactor/v2/client.gov24/api/keyfactor/v1/model_templates_template_retrieval_response.goManageability+ cleanup fieldsv24/api/keyfactor/v1/model_templates_template_update_request.gov24/api/keyfactor/v1/model_..._certificate_cleanup_time_units.gov24/api/keyfactor/v1/model_..._key_retention_policy.gov25/api/keyfactor/v1/model_templates_template_retrieval_response.goManageabilityfield