Add comprehensive logging and null reference protection#12
Open
bhillkeyfactor wants to merge 1 commit intorelease-1.1from
Open
Add comprehensive logging and null reference protection#12bhillkeyfactor wants to merge 1 commit intorelease-1.1from
bhillkeyfactor wants to merge 1 commit intorelease-1.1from
Conversation
Add extensive trace/error logging and null guards across all project files to aid debugging and prevent NullReferenceExceptions: - SslStoreCaProxy.cs: Harden Synchronize, Enroll, Revoke, GetSingleRecord, Initialize, ValidateEmails, GetEnrollmentResult - SslStoreClient.cs: Add logging/null checks to all API methods, constructor, and query pagination - KeyfactorClient.cs: Add logging/null checks to constructor, template update, and template query pagination - RequestManager.cs: Add logging/null checks to all request builders, MapReturnStatus, GetCertificateContent, and contact helpers - .gitignore: Add .claude/ directory Fixes sync NullReferenceException and operator precedence bug. AB#84952 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files changed
Test plan
AB#84952
Generated with Claude Code