Extend scanline comparisons for image padding#2619
Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom Apr 7, 2026
Merged
Extend scanline comparisons for image padding#2619bashbaug merged 1 commit intoKhronosGroup:mainfrom
bashbaug merged 1 commit intoKhronosGroup:mainfrom
Conversation
xinjin01
force-pushed
the
image-from-buffer-fill-padding
branch
3 times, most recently
from
81e2ff0 to
90891eb
Compare
Extend compare_scanlines to handle INT10X6/12X4/14X2 padding and per-channel SNORM INT8/INT16 comparisons, and switch pixel loads to memcpy to avoid unaligned access. Rework image_from_buffer_fill_check to compare rows via compare_scanlines. Apply clang-format to satisfy CTS formatting checks. No functional changes. Signed-off-by: Xin Jin <xin.jin@arm.com> Change-Id: I3f5f2e1477bff36e0d9d7c010db251e03f5626a2
xinjin01
force-pushed
the
image-from-buffer-fill-padding
branch
from
90891eb to
94eb79b
Compare
lakshmih
approved these changes
Mar 23, 2026
Contributor
|
Merging as discussed in the April 7th teleconference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend compare_scanlines to handle INT10X6/12X4/14X2 padding and per-channel SNORM INT8/INT16 comparisons, and switch pixel loads to memcpy to avoid unaligned access. Rework image_from_buffer_fill_check to compare rows via compare_scanlines.