fix(gastown): stop false-positive invariant violations in reconciler#1829
Closed
fix(gastown): stop false-positive invariant violations in reconciler#1829
Conversation
…every 5s Invariant 7: Exclude mayors from the 'working agent must have a hook' check — mayors are always working and intentionally hookless. Invariant 5: Widen valid convoy bead states to include in_progress and in_review, which are legitimate transient states while child beads are being worked on. Only flag truly unexpected states. Fixes #1364
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 1,983,373 tokens |
4 tasks
Contributor
Author
|
Work consolidated into the convoy landing PR — see #1862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workingand intentionally have no hook, causing false-positive violations every 5s.open/closedto includein_progressandin_reviewas valid transient states. Only flag truly unexpected states instead of all in-progress convoys.Verification
pnpm typecheckvia pre-push hook)Visual Changes
N/A
Reviewer Notes
These two invariant checks were firing every reconciler tick (5s), spamming logs with false positives. The fixes are minimal SQL filter changes with clear semantics.