feat(kiloclaw): default session.dmScope to 'main' on fresh install#1834
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
feat(kiloclaw): default session.dmScope to 'main' on fresh install#1834kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
Set config.session.dmScope = 'main' when KILOCLAW_FRESH_INSTALL is truthy, so DMs are routed to the main session on new installations. On subsequent boots the user's choice is left untouched.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 368,905 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On fresh KiloClaw installs, set
config.session.dmScope = 'main'so DMs are routed to the main session by default. This follows the existingKILOCLAW_FRESH_INSTALLpattern used forconfig.tools.profile. On subsequent boots, the user's choice is left untouched.generateBaseConfig()(right after thetools.profileblock) that setsconfig.session.dmScope = 'main'whenKILOCLAW_FRESH_INSTALL === 'true'Verification
pnpm test --run— 49 test files, 1151 tests passed (kiloclaw)pnpm test --run controller/src/config-writer.test.ts— 71 tests passed (4 new)pnpm typecheck— no errorspnpm lint— 0 warnings, 0 errorsVisual Changes
N/A
Reviewer Notes
The change only applies on fresh installs (
KILOCLAW_FRESH_INSTALL === 'true'), matching the exact same pattern used atconfig-writer.ts:203fortools.profile. ThewriteBaseConfig()function temporarily forcesKILOCLAW_FRESH_INSTALL = 'true'during config restores, sosession.dmScopewill also be reset to'main'on config restore — this is intentional and consistent with howtools.profilebehaves.