fix(logging): suppress health endpoint request logging#1959
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
fix(logging): suppress health endpoint request logging#1959kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
/health requests fire very frequently (health polls) and flood worker logs with noise. Add a QUIET_PATHS set to skip request logging for these high-frequency paths in both the KiloClaw worker and the gastown container control server.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 500,978 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthendpoint request logging in both the KiloClaw worker and the gastown container control server — these high-frequency health poll requests flood logs with noise, making it harder to spot meaningful requests.QUIET_PATHSSet for O(1) lookups and easy extensibility, following the same pattern introduced in fix(logging): exclude noisy health/telemetry paths from request logs #1948.Verification
pnpm typecheckpasses inkiloclaw/(tsgo --noEmit)pnpm lintpasses inkiloclaw/(oxlint, 0 warnings, 0 errors)pnpm typecheckpasses incloudflare-gastown/container/(tsc --noEmit)pnpm lintpasses incloudflare-gastown/container/(oxlint, 0 warnings, 0 errors)oxfmt --checkpasses on both changed filesVisual Changes
N/A
Reviewer Notes
QUIET_PATHSpattern is intentionally a named constant (not inline) so future noisy paths can be added in one place.url.pathname(already computed) against the set; the control-server usesc.req.path(Hono's parsed path). Both are consistent with how the rest of each middleware already accesses the path./healthroute is a public route handled before auth — it never reaches the catch-all proxy, so only thelogRequestmiddleware needs the suppression.Built for Mark by Kilo for Slack