fix(gastown): load ClipboardAddon so Mayor OSC 52 clipboard writes work#1998
Open
Githubguy132010 wants to merge 1 commit intoKilo-Org:mainfrom
Open
fix(gastown): load ClipboardAddon so Mayor OSC 52 clipboard writes work#1998Githubguy132010 wants to merge 1 commit intoKilo-Org:mainfrom
Githubguy132010 wants to merge 1 commit intoKilo-Org:mainfrom
Conversation
Agent-Logs-Url: https://github.com/Githubguy132010/cloud/sessions/87ae83fd-f8c7-4efb-b94d-5390d401da12 Co-authored-by: Githubguy132010 <145768128+Githubguy132010@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 109,084 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The xterm.js terminal in the Gastown component was missing the
@xterm/addon-clipboardaddon, which is required to handle OSC 52 escape sequences for clipboard writes. Applications running inside the terminal (such as Mayor) use OSC 52 to write text to the system clipboard. Without this addon, those clipboard write requests were silently dropped.This fix:
@xterm/addon-clipboardas a dependencyClipboardAddonalongside the existing xterm addonsNo architectural changes; purely additive.
Verification
pnpm typecheck)Visual Changes
N/A
Reviewer Notes
The
ClipboardAddonis loaded lazily in the samePromise.allblock as the other addons, keeping the SSR-safe lazy-loading pattern intact. The addon has no configuration options; default behaviour is to read/write the system clipboard via the Clipboard API, falling back gracefully when permissions are denied.