fix(reconciler): parameterize circuit breaker SQL query#1999
Merged
jrf0110 merged 2 commits intoconvoy/fix-reconciler-p0-p1-bug-fixes-from-audi/f071bd6c/headfrom Apr 4, 2026
Conversation
added 2 commits
April 4, 2026 15:01
Replace strftime template literal interpolation with a JS-computed cutoff timestamp passed as a bound SQL parameter. Same 30-minute window, no behavioral change.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 335,583 tokens |
jrf0110
merged commit 6c72827
into
convoy/fix-reconciler-p0-p1-bug-fixes-from-audi/f071bd6c/head
2 checks passed
jrf0110
deleted the
convoy/fix-reconciler-p0-p1-bug-fixes-from-audi/f071bd6c/gt/toast/098c4d8f
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced template literal interpolation in the circuit breaker SQL query (
strftime('...', 'now', '-${CIRCUIT_BREAKER_WINDOW_MINUTES} minutes')) with a JS-computed ISO 8601 cutoff timestamp passed as a bound SQL parameter. This eliminates string interpolation inside the SQL string while preserving the same 30-minute window behavior. No functional change.Verification
Visual Changes
N/A
Reviewer Notes
WIP: container eviction savecommit with no file changes — can be squashed on merge.?bound parameters with thequery()helper instead of interpolating values into SQL strings.