Skip to content

fix(reconciler): parameterize circuit breaker SQL query #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrf0110 merged 1 commit into from
Apr 5, 2026
+3 −2
Merged

fix(reconciler): parameterize circuit breaker SQL query #2013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cloudflare-gastown/src/dos/town/reconciler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const CIRCUIT_BREAKER_WINDOW_MINUTES = 30;
* beads that eventually succeeded (status = 'closed').
*/
function checkDispatchCircuitBreaker(sql: SqlStorage): Action[] {
const cutoff = new Date(Date.now() - CIRCUIT_BREAKER_WINDOW_MINUTES * 60_000).toISOString();
const rows = z
.object({ failure_count: z.number() })
.array()
Expand All @@ -61,11 +62,11 @@ function checkDispatchCircuitBreaker(sql: SqlStorage): Action[] {
/* sql */ `
SELECT count(*) as failure_count
FROM ${beads}
WHERE ${beads.last_dispatch_attempt_at} > strftime('%Y-%m-%dT%H:%M:%fZ', 'now', '-${CIRCUIT_BREAKER_WINDOW_MINUTES} minutes')
WHERE ${beads.last_dispatch_attempt_at} > ?
AND ${beads.dispatch_attempts} > 0
AND ${beads.status} != 'closed'
`,
[]
[cutoff]
),
]);

Expand Down