fix(reconciler): P0+P1 bug fixes from audit #1986 (v3)#2031
fix(reconciler): P0+P1 bug fixes from audit #1986 (v3)#2031jrf0110 wants to merge 1 commit intogastown-stagingfrom
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| if ( | ||
| request.processStatus === 'success' || | ||
| request.processStatus === 'failed' || | ||
| request.processStatus === 'inprogress' |
There was a problem hiding this comment.
WARNING: inprogress now suppresses all retries for KiloClaw chat deliveries
This request is marked inprogress before the outbound send-chat-message fetch, and processWebhookMessage() later acks any non-captured request that does not have a cloudAgentSessionId. If the worker crashes or the fetch throws after the status update but before success/failure is persisted, the queue retry will skip this request forever and the scheduled/webhook run is lost.
| 'Content-Type': 'application/json', | ||
| 'User-Agent': 'Gastown-Refinery/1.0', | ||
| }, | ||
| body: JSON.stringify({ merge_method: 'merge' }), |
There was a problem hiding this comment.
WARNING: Auto-merge is not pinned to the reviewed head SHA
This merge request only sends merge_method, so GitHub will merge whatever commit is at the PR head when this call arrives. A push that lands after checkPRFeedback() runs but before this request can therefore merge unreviewed code. Please include the expected sha in the merge payload and treat a mismatch as a retry/reset condition.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)N/A Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 file)
Reviewed by gpt-5.4-20260305 · 480,049 tokens |
… metadata column Rebase onto gastown-staging to preserve NULL rig_id COALESCE handling (P0) and source bead state guard in review-queue.ts (P1). Changes on top of gastown-staging: - Parameterize circuit breaker SQL: compute cutoff in JS and bind as parameter instead of interpolating into query string - Remove duplicate b.metadata column in MR beads SELECT query
jrf0110
force-pushed
the
convoy/fix-reconciler-p0-p1-bug-fixes-from-audi/892c7c4a/head
branch
from
dbf82c3 to
4bd4fea
Compare
1 participant
Summary
CIRCUIT_BREAKER_WINDOW_MINUTESinto the query string via a template literal. Same 30-minute window, no behavioral change.b.metadatain MR beads SQL SELECT query (line ~1054).Verification
pnpm typecheckpasses (ran via pre-push hook and manually)pnpm format:checkpasses (ran via pre-push hook)in_reviewstatus check preserved in review-queue.tscompleteReviewWithResultb.metadatacolumn removed from MR beads queryVisual Changes
N/A
Reviewer Notes
main, which would have reverted two gastown-staging bug fixes (NULL rig_id handling and source bead state guard from d36364d). This version is rebased onto gastown-staging so those fixes are preserved.