Skip to content

feat(webhook-triggers): admin ui#49

Open
pandemicsyn wants to merge 3 commits intomainfrom
florian/chore/webhooks-admin-ui
Open

feat(webhook-triggers): admin ui#49
pandemicsyn wants to merge 3 commits intomainfrom
florian/chore/webhooks-admin-ui

Conversation

@pandemicsyn
Copy link
Contributor

@pandemicsyn pandemicsyn commented Feb 6, 2026

Basic readonly admin ui for webhook triggers.

https://www.loom.com/share/45783d48ecc64d51b6e3fbceac5a7db9

@pandemicsyn pandemicsyn requested a review from a team February 6, 2026 00:04
</pre>
{isAdminView ? (
<p className="text-muted-foreground text-xs">
Payload body length: {request.body.length} bytes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: request.body.length is characters, not bytes

JS string .length counts UTF-16 code units, so the displayed value can be wrong for non-ASCII payloads. If you want bytes, compute it.

Suggested change
Payload body length: {request.body.length} bytes
Payload body length: {new TextEncoder().encode(request.body).length} bytes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@kiloconnect
Copy link
Contributor

kiloconnect bot commented Feb 6, 2026

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 1

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
src/routers/admin-webhook-triggers-router.ts 204 Admin endpoint returns full request headers/body even though admin UI masks them (data still exposed via network/DevTools).

SUGGESTION

File Line Issue
src/app/(app)/cloud/webhooks/[triggerId]/requests/WebhookRequestsContent.tsx 577 request.body.length counts characters/UTF-16 code units, not bytes; display can be incorrect for non-ASCII payloads.
Files Reviewed (14 files)
  • src/app/(app)/cloud/webhooks/[triggerId]/requests/WebhookRequestsContent.tsx - 2 issues
  • src/app/admin/components/OrganizationAdmin/OrganizationAdminDashboard.tsx
  • src/app/admin/components/OrganizationAdmin/OrganizationAdminWebhooks.tsx
  • src/app/admin/components/UserAdmin/UserAdminAccountInfo.tsx
  • src/app/admin/organizations/[id]/webhooks/[triggerId]/page.tsx
  • src/app/admin/organizations/[id]/webhooks/page.tsx
  • src/app/admin/users/[id]/webhooks/[triggerId]/page.tsx
  • src/app/admin/users/[id]/webhooks/page.tsx
  • src/app/admin/webhooks/AdminWebhookTriggerDetails.tsx
  • src/app/admin/webhooks/AdminWebhookTriggersList.tsx
  • src/components/webhook-triggers/TriggersTable.tsx
  • src/components/webhook-triggers/WebhookTriggersHeader.tsx
  • src/routers/admin-router.ts
  • src/routers/admin-webhook-triggers-router.ts - 1 issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants