override resonant default for account_get to resolve safelinks issue#440
Merged
BryonLewis merged 1 commit intomainfrom Mar 18, 2026
Merged
override resonant default for account_get to resolve safelinks issue#440BryonLewis merged 1 commit intomainfrom
BryonLewis merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding users at some institutions having issues with the django-allauth email verification link:
I'm wondering if Safelinks are pre-GETing the verification email link, so when a user opens it in their email, it is already verified and 'expired' because of this setting: https://github.com/kitware-resonant/cookiecutter-resonant/blob/master/django-resonant-settings/resonant_settings/allauth.py#L53 - ACCOUNT_CONFIRM_EMAIL_ON_GET=True
https://docs.allauth.org/en/latest/account/configuration.html#email-verification - documentation is just below this link.
I think when set to FALSE just adds an extra click to verification but should prevent Safelinks from triggering verification via GET before a user looks at the email. The allauth documentation even mentions adding some JS to hit the POST endpoint automatically on the template so it behaves like a single click.