feat(vtkProperty): add vtkProperty edgeOpacity#3470
Open
daker wants to merge 1 commit intoKitware:masterfrom
Open
feat(vtkProperty): add vtkProperty edgeOpacity#3470daker wants to merge 1 commit intoKitware:masterfrom
daker wants to merge 1 commit intoKitware:masterfrom
Conversation
Collaborator
Author
|
@sankhesh could you help us review the pending WebGPU PRs? |
Collaborator
Author
|
@finetjul sorry for the noise, how can we move forward? also who would be the right person to review the WebGPU(code) PRs? |
finetjul
requested changes
Apr 15, 2026
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
Oups, I had a pending review that never got submitted.
Here you go.
I can review such "easy" PR.
| publicAPI.getEdgeOpacity = () => | ||
| model.edgeOpacity == null ? model.opacity : model.edgeOpacity; | ||
|
|
||
| publicAPI.setEdgeOpacity = (edgeOpacity) => { |
| model.classHierarchy.push('vtkProperty'); | ||
|
|
||
| publicAPI.getEdgeOpacity = () => | ||
| model.edgeOpacity == null ? model.opacity : model.edgeOpacity; |
Member
There was a problem hiding this comment.
it is not obvious for the consumer that he/she will get the opacity if edgeOpacity is null. It's counter intuitive. And he/she won't know if it is null or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Results
fixes: #3461
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting