fix(ImageMapper): check cardinal neighbors in label outline border detection#3481
Merged
finetjul merged 1 commit intoKitware:masterfrom Apr 12, 2026
Merged
Conversation
…tection The label outline border detection loop used `if (i == 0 || j == 0)` which skips all cardinal-direction neighbors (up/down/left/right), only checking diagonals. Changed to `if (i == 0 && j == 0)` to skip only the center pixel, matching ImageResliceMapper's correct behavior. Fixes Kitware#3480
|
🎉 This PR is included in version 35.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The label outline border detection loop used
if (i == 0 || j == 0)which skips all cardinal-direction neighbors (up/down/left/right), only checking diagonals. Changed toif (i == 0 && j == 0)to skip only the center pixel.Fixes #3480