Skip to content

Fix/cross package imports [#404]#431

Closed
Spyderma9 wants to merge 6 commits intomainfrom
fix/cross-package-imports
Closed

Fix/cross package imports [#404]#431
Spyderma9 wants to merge 6 commits intomainfrom
fix/cross-package-imports

Conversation

@Spyderma9
Copy link
Copy Markdown
Contributor

@Spyderma9 Spyderma9 commented Mar 31, 2026

Why

Need to remove fragile cross-package imports in the db seed script while keeping the dependency graph safe

What

Closes: #404

Refactored the db seed script to stop relying on fragile cross-package wiring
Kept package dependencies aligned to avoid introducing cycles between db/api/utils
Fixed minor cleanup issues found during review (including message text consistency)
Updated lockfile to match dependency/export changes

Test Plan

Ran pnpm --filter @forge/db typecheck successfully
Ran pnpm install successfully
Verified the seed script resolves cleanly with no diagnostics
Confirmed no circular dependency warning remains from this change set

Checklist

  • Database: No schema changes, OR I have contacted the Development Lead to run db:push before merging
  • Environment Variables: No environment variables changed, OR I have contacted the Development Lead to modify them on Coolify BEFORE merging.

@Spyderma9 Spyderma9 self-assigned this Mar 31, 2026
@Spyderma9 Spyderma9 requested a review from a team as a code owner March 31, 2026 00:38
@Spyderma9 Spyderma9 added Minor Small change - 1 reviewer required Utils Changes to the utils package labels Mar 31, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

Warning

Rate limit exceeded

@Spyderma9 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 12 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 12 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9e41585f-872f-415c-ad58-1582680e6afc

📥 Commits

Reviewing files that changed from the base of the PR and between 2a698f4 and f4e9434.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/api/package.json
  • packages/db/package.json
  • packages/db/scripts/seed_devdb.ts
  • packages/utils/package.json
  • packages/utils/src/discord.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cross-package-imports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Spyderma9 Spyderma9 closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Small change - 1 reviewer required Utils Changes to the utils package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve cross-package imports

1 participant