Open
Conversation
Collaborator
|
Hi! Thanks for your small refactor. For this PR it seems like you edited the I would like to point you to our contribution guide which describes how to contribute, run tests, the kdocs preprocessor etc. For now, if you edit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helper Function: The
toNotNullableName()extension function encapsulates the logic for determining how to transform amarkerNameortypeFqName. This reduces code duplication across the different field types.Readability: By using a helper function, we make it clear what transformation is being applied to the names, improving overall readability.
Maintainability: If the logic for determining how to handle names changes in the future, you only need to update it in one place.