Incorporated SRV format in connection string by Krish-cloudsufi · Pull Request #1 · Krish-cloudsufi/mongodb-plugins

Krish-cloudsufi · 2025-04-03T09:28:24Z

Incorporated SRV format in connection string and introduced a toggle property in MongoDB plugin UI.

vikasrathee-cs · 2025-04-03T09:36:08Z

pom.xml

          <cdapArtifacts>
-            <parent>system:cdap-data-pipeline[6.8.0-SNAPSHOT,7.0.0-SNAPSHOT)</parent>
-            <parent>system:cdap-data-streams[6.8.0-SNAPSHOT,7.0.0-SNAPSHOT)</parent>
+            <parent>system:cdap-data-pipeline[6.11.0-SNAPSHOT,7.0.0-SNAPSHOT)</parent>


revert this change

vikasrathee-cs · 2025-04-03T09:36:18Z

pom.xml

    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <!-- version properties -->
-    <cdap.version>6.8.0-SNAPSHOT</cdap.version>
+    <cdap.version>6.11.0-SNAPSHOT</cdap.version>


revert this change

vikasrathee-cs · 2025-04-03T09:36:32Z

src/main/java/io/cdap/plugin/MongoDBConfig.java

+  @Name(MongoDBConstants.USE_SRV)
+  @Description("Enable SRV format for connection string")
+  @Nullable
+  private Boolean useSRV;


make it primitive at all places

vikasrathee-cs · 2025-04-03T09:37:57Z

src/main/java/io/cdap/plugin/MongoDBConfig.java

    if (!containsMacro(MongoDBConstants.HOST) && Strings.isNullOrEmpty(host)) {
      throw new InvalidConfigPropertyException("Host must be specified", MongoDBConstants.HOST);
    }
-    if (!containsMacro(MongoDBConstants.PORT)) {


keep this condition as when useSRV is not macro and not true, this validation is required

vikasrathee-cs · 2025-04-03T09:43:12Z

src/main/java/io/cdap/plugin/MongoDBConfig.java

  private String password;

+  @Name(MongoDBConstants.USE_SRV)
+  @Description("Enable SRV format for connection string")


use Connect Using SRV String as field and label name in widget and also add the same in md doc file

Add same description that you have added in md file

vikasrathee-cs · 2025-04-04T11:21:39Z

src/main/java/io/cdap/plugin/MongoDBConfig.java

+  @Name(MongoDBConstants.USE_SRV)
+  @Description("Enable SRV format for connection string")
+  @Nullable
+  private boolean useSRV;


change field name also

Shall I make it as connectUsingSRV ?

this name should be same as given in widget.json

vikasrathee-cs · 2025-04-04T11:23:56Z

src/main/java/io/cdap/plugin/MongoDBConfig.java

    return password;
  }

+  public boolean isUseSRV() {


adding 'is' as a prefix doesnt make much sense, keep it just connectUsingSRVString

vikasrathee-cs · 2025-04-04T11:24:51Z

src/main/java/io/cdap/plugin/MongoDBConfig.java


    return connectionStringBuilder.toString();
+
+


remove blank lines

vikasrathee-cs · 2025-04-04T11:25:18Z

src/main/java/io/cdap/plugin/MongoDBConstants.java

  public static final String PASSWORD = "password";

+  /**
+   *


Add a small description

vikasrathee-cs · 2025-04-04T11:25:43Z

src/main/java/io/cdap/plugin/batch/sink/MongoDBBatchSink.java

    public MongoDBSinkConfig(String referenceName, String host, int port, String database, String collection,
-                             String user, String password, String connectionArguments, String idField) {
-      super(referenceName, host, port, database, collection, user, password, connectionArguments);
+                             String user, String password, Boolean useSRV, String connectionArguments, String idField) {


make boolean primitive at all places

vikasrathee-cs · 2025-04-04T11:27:11Z

docs/MongoDB-batchsource.md


 **Password:** Password to use to connect to the specified database.

+**Connect Using SRV String:** Toggle to determine whether to use an SRV connection string for MongoDB. It can be


add same to sink also

…ig and md

vikasrathee-cs · 2025-04-07T11:24:02Z

src/main/java/io/cdap/plugin/MongoDBConstants.java

+  /**
+   * Configuration property name used to specify whether to use an SRV Connection string for MongoDB.
+   */
+  public static final String USE_SRV = "connectUsingSRVString";


rename this also to CONNECT_USING_SRV_STRING

sgarg-CS · 2025-04-11T07:31:48Z

src/main/java/io/cdap/plugin/MongoDBConfig.java

+  @Description("Toggle to determine whether to use an SRV connection string for MongoDB. It can be " +
+    "enabled if the MongoDB deployment supports SRV DNS records for connection resolution.")
+  @Nullable
+  private boolean connectUsingSRVString;


I see this condition below to check this plugin property whether it contains macro or not, but the plugin property is not annotated with @macro annotation.

sgarg-CS · 2025-04-11T08:35:38Z

src/test/java/io/cdap/plugin/batch/MongoDBConfigBuilder.java

  protected String collection;
  protected String user;
  protected String password;
+  protected Boolean connectUsingSRVString;


change to boolean ? as the main config file uses the primitive type for the same variable.
Boolean can cause NPE, if the variable is not set.

sgarg-CS · 2025-04-11T16:58:57Z

LGTM.

Krish-cloudsufi added 2 commits April 3, 2025 13:52

Changed getConnectionString to incorporate SRV fomrat

e05342a

Added widget attributes for the srv toggle

48971e9

vikasrathee-cs reviewed Apr 3, 2025

View reviewed changes

Krish-cloudsufi added 6 commits April 3, 2025 16:04

Reversed changes in pom and added validation condition for PORT

26d95a6

Made useSRV as primitive

56334ec

Renamed field name and label name in widgets and md

ba1cba7

Added label name in widgets-batchsink

62ae69e

Updated Javadoc for getConnectionString

1af6b88

Added tests for getConnectionString

c9d58af

vikasrathee-cs reviewed Apr 4, 2025

View reviewed changes

src/main/java/io/cdap/plugin/MongoDBConfig.java Outdated

return connectionStringBuilder.toString();

Copy link

vikasrathee-cs Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank lines

vikasrathee-cs reviewed Apr 4, 2025

View reviewed changes

Renamed useSRV as connectUsingSRVString and added description in conf…

87ef57b

…ig and md

vikasrathee-cs reviewed Apr 7, 2025

View reviewed changes

Krish-cloudsufi added 2 commits April 7, 2025 17:26

Renamed useSRV as ConnectUsingSRV

c168339

Updated MongoDBConfigTest to handle SRV string

51fcc54

sgarg-CS reviewed Apr 11, 2025

View reviewed changes

Made Connect Using SRV String as Macro

83ea240

sgarg-CS reviewed Apr 11, 2025

View reviewed changes

Krish-cloudsufi added 2 commits April 11, 2025 14:37

Changed ConnectUsingSRV to primitive boolean in MongoDBConfigBuilder

2d18182

changed return statemnet for connectUsingSrv

5e4f7b6


		Password: Password to use to connect to the specified database.

		Connect Using SRV String: Toggle to determine whether to use an SRV connection string for MongoDB. It can be

Conversation

Krish-cloudsufi commented Apr 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vikasrathee-cs Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vikasrathee-cs Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vikasrathee-cs Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgarg-CS Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgarg-CS commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vikasrathee-cs Apr 3, 2025 •

edited

Loading

vikasrathee-cs Apr 3, 2025 •

edited

Loading

vikasrathee-cs Apr 4, 2025 •

edited

Loading

sgarg-CS Apr 11, 2025 •

edited

Loading