fix from_cursor_pos for Neovim after fd1e019#1430
Conversation
|
There are more instances of |
|
@leiserfg sure! Do you have a specific spot in the code-base where shims/wrappers like that belong? |
|
Just make a file in utils. |
|
@leiserfg Can do. Although I already did have a look around in the meantime. Wouldn't |
This is done to normalize the throwing behavior of the old version to the behavior of the new version, which returns errors as values. Closes L3MON4D3#1429
|
Done. Weirdly enough, call sites in |
|
Thank you for the PR @kmoschcau, and @leiserfg for handling it 🙏🙏 |
|
Okay, I can't get the tests for master running right now, but this change seem correct, and works for 0.7 and 0.9, so I'll take it :) |
Closes #1429
See: neovim/neovim@fd1e019
I'm not sure how to best achieve backward compatibility here. I can look into doing it via the return values or whether the function throws or not, if you want.