fix in group accuracy in ulits/toolkit.py#99
Open
raziqueA wants to merge 1 commit intoLAMDA-CL:masterfrom
Open
fix in group accuracy in ulits/toolkit.py#99raziqueA wants to merge 1 commit intoLAMDA-CL:masterfrom
raziqueA wants to merge 1 commit intoLAMDA-CL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when calculating group accuracy in ./ulits/toolkit.py file, the accuracy for the last group in each task is calculated incorrectly.
For example CIFAR100, which has classes [0, 1, 2, ..., 99] and Base 0 Increment 10 case, the issue arises when the code attempts to compute the accuracy for each task.
In the first task with a base of 0 and an increment of 10, the code only calculates the accuracy for the first 9 classes ([0, 1, 2, ..., 8]), while it should be calculating the accuracy for all 10 classes ([0, 1, 2, ..., 9]).
In subsequent tasks, for example, task 2 with 20 classes ([0, 1, 2, ..., 19]), the code correctly computes the accuracy for the first 10 classes (task 1) but then inaccurately computes the accuracy for task 2 by only considering classes from 10 to 18, missing the last class (19).
similarly happens for all the tasks