Move StaticFiles from the base project to the Website project#970
Open
Slendy wants to merge 2 commits intoLBPUnion:mainfrom
Open
Move StaticFiles from the base project to the Website project#970Slendy wants to merge 2 commits intoLBPUnion:mainfrom
Slendy wants to merge 2 commits intoLBPUnion:mainfrom
Conversation
sudokoko
approved these changes
Jan 21, 2024
Member
sudokoko
left a comment
sudokoko
left a comment
There was a problem hiding this comment.
feel free to re-request review if you end up changing something
Zaprit
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be a breaking change for some installations
If you rely on a symbolic link or a manual copy operation to put website files in the data directory you will need to change your installation to instead copy from
ProjectLighthouse.Servers.Website\StaticFiles. I'm still not sure if this is the best approach for storing these static files. I think this could be the opportunity to include them in the output of the build and to pull from that instead of them being in the data directory. I'm open to hearing discussion from others though.