Skip to content

Weight drop alert update#1501

Open
kollil wants to merge 17 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_WeightDropAlertUpdate
Open

Weight drop alert update#1501
kollil wants to merge 17 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_WeightDropAlertUpdate

Conversation

@kollil
Copy link
Collaborator

@kollil kollil commented Oct 10, 2025

Made changes to the query.

@kollil kollil requested a review from Ohsudev October 10, 2025 23:15
Ohsudev
Ohsudev previously approved these changes Oct 10, 2025
@kollil kollil requested a review from Ohsudev January 9, 2026 21:33
Ohsudev
Ohsudev previously approved these changes Jan 9, 2026
1. Use most recent weight compared to only one previous weight and not all previous weights in that time frame.
2. For the previous weight: use the weight that is at least 30 days prior (not sooner) and up to 100 days prior.
1. Use most recent weight compared to only one previous weight and not all previous weights in that time frame.
2. For the previous weight: use the weight that is at least 30 days prior (not sooner) and up to 100 days prior.
@kollil kollil requested a review from Ohsudev March 5, 2026 01:25
Ohsudev
Ohsudev previously approved these changes Mar 5, 2026
@kollil
Copy link
Collaborator Author

kollil commented Mar 5, 2026

@labkey-martyp, I am getting team errors unrelated to my update. Could you check once when you get a chance please.
I must install this program tonight for the user as we have a code freeze till March 12th.

Thanks
Lakshmi

@kollil kollil requested a review from Ohsudev March 5, 2026 21:12
Ohsudev
Ohsudev previously approved these changes Mar 5, 2026
@labkey-martyp
Copy link
Contributor

@labkey-martyp, I am getting team errors unrelated to my update. Could you check once when you get a chance please. I must install this program tonight for the user as we have a code freeze till March 12th.

Thanks Lakshmi

Hi Lakshmi, while running your code please run query validation. Warnings are fine but Errors need to be cleaned up.

@kollil
Copy link
Collaborator Author

kollil commented Mar 5, 2026

@labkey-martyp, I am getting team errors unrelated to my update. Could you check once when you get a chance please. I must install this program tonight for the user as we have a code freeze till March 12th.
Thanks Lakshmi

Hi Lakshmi, while running your code please run query validation. Warnings are fine but Errors need to be cleaned up.

@labkey-martyp , I finished validating the queries. No errors in the two queries I have in this PR, but a few warnings found.
Still tests failed.

@labkey-martyp
Copy link
Contributor

@kollil If you're adding new datasets they need to be added in datasets_metadata.xml and datasets_manifest.xml.

image

@labkey-martyp
Copy link
Contributor

labkey-martyp commented Mar 6, 2026

@kollil If you're adding new datasets they need to be added in datasets_metadata.xml and datasets_manifest.xml.

image

Or if this is a query it's missing from this PR.

@labkey-martyp, I am not able to open this image. Got error -
"This private-user-images.githubusercontent.com page can’t be found"

@kollil
Copy link
Collaborator Author

kollil commented Mar 6, 2026

@labkey-martyp , I have never added the new queries to these datasets before. Is this something new?
These two are just queries I wrote, not built-in tables.

@kollil If you're adding new datasets they need to be added in datasets_metadata.xml and datasets_manifest.xml.

image

@labkey-martyp
Copy link
Contributor

@labkey-martyp , I have never added the new queries to these datasets before. Is this something new? These two are just queries I wrote, not built-in tables.

@kollil If you're adding new datasets they need to be added in datasets_metadata.xml and datasets_manifest.xml.
image

Oh sorry @kollil , not sure why the image didn't come through. The query validation is saying study.WeightManagementMMAData is not found. If this is a query, the sql file needs to be added to this PR. If it's a dataset, it needs to be added in datasets_metadata and datasets_manifest.

@kollil
Copy link
Collaborator Author

kollil commented Mar 6, 2026

@labkey-martyp , I have never added the new queries to these datasets before. Is this something new? These two are just queries I wrote, not built-in tables.

@kollil If you're adding new datasets they need to be added in datasets_metadata.xml and datasets_manifest.xml.
image

Oh sorry @kollil , not sure why the image didn't come through. The query validation is saying study.WeightManagementMMAData is not found. If this is a query, the sql file needs to be added to this PR. If it's a dataset, it needs to be added in datasets_metadata and datasets_manifest.

@labkey-martyp, That's interesting. study.WeightManagementMMAData is already in production and is there since we have Labkey and created by Ben. I was just using that table in my new query.

@labkey-martyp
Copy link
Contributor

@labkey-martyp , I have never added the new queries to these datasets before. Is this something new? These two are just queries I wrote, not built-in tables.

@kollil If you're adding new datasets they need to be added in datasets_metadata.xml and datasets_manifest.xml.
image

Oh sorry @kollil , not sure why the image didn't come through. The query validation is saying study.WeightManagementMMAData is not found. If this is a query, the sql file needs to be added to this PR. If it's a dataset, it needs to be added in datasets_metadata and datasets_manifest.

@labkey-martyp, That's interesting. study.WeightManagementMMAData is already in production and is there since we have Labkey and created by Ben. I was just using that table in my new query.

If you're using it in your checked-in code, it needs to be available in the same context. User defined query won't work. You can copy the sql into a new .sql file of the same name. Before you install this PR on production, delete the user-defined version of the query so there is no confusion which one is being used.

@labkey-martyp
Copy link
Contributor

study.WeightManagementMMAData

@kollil study.WeightManagementMMAData was created by you in 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants